Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2410903002:
Set min and max rate on caller and on callee side. (Closed)
DescriptionSet min and max rate on caller and on callee side.
BUG=webrtc:6518
Committed: https://crrev.com/53fe19d6f351ef396a62cd751878770665d1d989
Cr-Commit-Position: refs/heads/master@{#14666}
Patch Set 1 #
Total comments: 4
Patch Set 2 : Respond to comments of the sun #Messages
Total messages: 21 (10 generated)
The CQ bit was checked by michaelt@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Description was changed from ========== Set min and max rate on caller and on callee side. BUG= ========== to ========== Set min and max rate on caller and on callee side. BUG=webrtc:6518 ==========
michaelt@webrtc.org changed reviewers: + minyue@webrtc.org, stefan@webrtc.org
solenberg@webrtc.org changed reviewers: + solenberg@webrtc.org
https://codereview.webrtc.org/2410903002/diff/1/webrtc/media/engine/webrtcvoi... File webrtc/media/engine/webrtcvoiceengine.cc (right): https://codereview.webrtc.org/2410903002/diff/1/webrtc/media/engine/webrtcvoi... webrtc/media/engine/webrtcvoiceengine.cc:1172: void RecreateAudioSendStream(const SendCodecSpec& send_codec_spec) { Thread check should happen before mutating internal state. https://codereview.webrtc.org/2410903002/diff/1/webrtc/media/engine/webrtcvoi... webrtc/media/engine/webrtcvoiceengine.cc:1184: void RecreateAudioSendStream() { This is an internal utility - make it private. There should be no reason for a client to recreate the stream without having set new state.
https://codereview.webrtc.org/2410903002/diff/1/webrtc/media/engine/webrtcvoi... File webrtc/media/engine/webrtcvoiceengine.cc (right): https://codereview.webrtc.org/2410903002/diff/1/webrtc/media/engine/webrtcvoi... webrtc/media/engine/webrtcvoiceengine.cc:1172: void RecreateAudioSendStream(const SendCodecSpec& send_codec_spec) { On 2016/10/11 15:22:15, the sun wrote: > Thread check should happen before mutating internal state. Acknowledged. https://codereview.webrtc.org/2410903002/diff/1/webrtc/media/engine/webrtcvoi... webrtc/media/engine/webrtcvoiceengine.cc:1184: void RecreateAudioSendStream() { On 2016/10/11 15:22:15, the sun wrote: > This is an internal utility - make it private. There should be no reason for a > client to recreate the stream without having set new state. Acknowledged.
lgtm
lgtm
rs-lgtm
The CQ bit was checked by michaelt@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/9243)
The CQ bit was checked by michaelt@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Message was sent while issue was closed.
Description was changed from ========== Set min and max rate on caller and on callee side. BUG=webrtc:6518 ========== to ========== Set min and max rate on caller and on callee side. BUG=webrtc:6518 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Set min and max rate on caller and on callee side. BUG=webrtc:6518 ========== to ========== Set min and max rate on caller and on callee side. BUG=webrtc:6518 Committed: https://crrev.com/53fe19d6f351ef396a62cd751878770665d1d989 Cr-Commit-Position: refs/heads/master@{#14666} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/53fe19d6f351ef396a62cd751878770665d1d989 Cr-Commit-Position: refs/heads/master@{#14666} |
