Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Side by Side Diff: webrtc/tools/event_log_visualizer/analyzer.cc

Issue 2410433002: Fix delay plot crash in event_log_visualizer. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 1086 matching lines...) Expand 10 before | Expand all | Expand 10 after
1097 if (kv.first.GetDirection() == PacketDirection::kIncomingPacket) { 1097 if (kv.first.GetDirection() == PacketDirection::kIncomingPacket) {
1098 for (const LoggedRtcpPacket& rtcp_packet : kv.second) 1098 for (const LoggedRtcpPacket& rtcp_packet : kv.second)
1099 incoming_rtcp.insert( 1099 incoming_rtcp.insert(
1100 std::make_pair(rtcp_packet.timestamp, &rtcp_packet)); 1100 std::make_pair(rtcp_packet.timestamp, &rtcp_packet));
1101 } 1101 }
1102 } 1102 }
1103 1103
1104 SimulatedClock clock(0); 1104 SimulatedClock clock(0);
1105 NullBitrateController null_controller; 1105 NullBitrateController null_controller;
1106 TransportFeedbackAdapter feedback_adapter(&clock, &null_controller); 1106 TransportFeedbackAdapter feedback_adapter(&clock, &null_controller);
1107 feedback_adapter.InitBwe();
1107 1108
1108 TimeSeries time_series; 1109 TimeSeries time_series;
1109 time_series.label = "Network Delay Change"; 1110 time_series.label = "Network Delay Change";
1110 time_series.style = LINE_DOT_GRAPH; 1111 time_series.style = LINE_DOT_GRAPH;
1111 int64_t estimated_base_delay_ms = std::numeric_limits<int64_t>::max(); 1112 int64_t estimated_base_delay_ms = std::numeric_limits<int64_t>::max();
1112 1113
1113 auto rtp_iterator = outgoing_rtp.begin(); 1114 auto rtp_iterator = outgoing_rtp.begin();
1114 auto rtcp_iterator = incoming_rtcp.begin(); 1115 auto rtcp_iterator = incoming_rtcp.begin();
1115 1116
1116 auto NextRtpTime = [&]() { 1117 auto NextRtpTime = [&]() {
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
1167 point.y -= estimated_base_delay_ms; 1168 point.y -= estimated_base_delay_ms;
1168 // Add the data set to the plot. 1169 // Add the data set to the plot.
1169 plot->series_list_.push_back(std::move(time_series)); 1170 plot->series_list_.push_back(std::move(time_series));
1170 1171
1171 plot->SetXAxis(0, call_duration_s_, "Time (s)", kLeftMargin, kRightMargin); 1172 plot->SetXAxis(0, call_duration_s_, "Time (s)", kLeftMargin, kRightMargin);
1172 plot->SetSuggestedYAxis(0, 10, "Delay (ms)", kBottomMargin, kTopMargin); 1173 plot->SetSuggestedYAxis(0, 10, "Delay (ms)", kBottomMargin, kTopMargin);
1173 plot->SetTitle("Network Delay Change."); 1174 plot->SetTitle("Network Delay Change.");
1174 } 1175 }
1175 } // namespace plotting 1176 } // namespace plotting
1176 } // namespace webrtc 1177 } // namespace webrtc
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698