Remove useless debugging code

Remove useless debugging code

It would be enough to say we're removing EnableSrtpDebugging because
it's never called, but the story is a bit more interesting.

libsrtp's debugging facilities are gated behind the reasonably-named
ENABLE_DEBUGGING macro:

https://chromium.googlesource.com/chromium/deps/libsrtp/+/b17c065a8a63725eca216fd461984f82c331dd07/srtp/crypto/include/err.h#186

This code was imported to WebRTC from libjingle, but neither WebRTC or
Chromium ever set ENABLE_DEBUGGING. Even if someone had ever called
EnableSrtpDebugging, it wouldn't have done anything.

BUG=0
Committed: https://crrev.com/8ff52cc7bc4e72f8967f15450aec30a6f766a3f5
Cr-Commit-Position: refs/heads/master@{#14592}

[mattdr-at-webrtc.org, 2016-10-10 04:03:24]

mattdr@webrtc.org changed reviewers:
+ deadbeef@webrtc.org

[Taylor Brandstetter, 2016-10-10 19:42:26]

lgtm. Though may want to check with Peter if anyone uses this to debug SRTP in
local builds.

[mattdr-at-webrtc.org, 2016-10-10 22:04:49]

On 2016/10/10 19:42:26, Taylor Brandstetter wrote:
> lgtm. Though may want to check with Peter if anyone uses this to debug SRTP in
> local builds.

I can't find any reference to SRTP_DEBUG on the public Internet or within
Google. Pretty confident this code was never live.

[mattdr-at-webrtc.org, 2016-10-10 22:04:53]

The CQ bit was checked by mattdr@webrtc.org

[commit-bot: I haz the power, 2016-10-10 22:04:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[mattdr-at-webrtc.org, 2016-10-10 22:22:49]

Description was changed from

==========
Remove useless debugging code

It would be enough to say we're removing EnableSrtpDebugging because
it's never called, but the story is a bit more interesting.

libsrtp's debugging facilities are gated behind the reasonably-named
ENABLE_DEBUGGING macro:

https://chromium.googlesource.com/chromium/deps/libsrtp/+/b17c065a8a63725eca2...

This code was imported to WebRTC from libjingle, but neither WebRTC or
Chromium ever set ENABLE_DEBUGGING. Even if someone had ever called
EnableSrtpDebugging, it wouldn't have done anything.

BUG=
==========

to

==========
Remove useless debugging code

It would be enough to say we're removing EnableSrtpDebugging because
it's never called, but the story is a bit more interesting.

libsrtp's debugging facilities are gated behind the reasonably-named
ENABLE_DEBUGGING macro:

https://chromium.googlesource.com/chromium/deps/libsrtp/+/b17c065a8a63725eca2...

This code was imported to WebRTC from libjingle, but neither WebRTC or
Chromium ever set ENABLE_DEBUGGING. Even if someone had ever called
EnableSrtpDebugging, it wouldn't have done anything.

BUG=0
==========

[commit-bot: I haz the power, 2016-10-10 22:56:58]

Description was changed from

==========
Remove useless debugging code

It would be enough to say we're removing EnableSrtpDebugging because
it's never called, but the story is a bit more interesting.

libsrtp's debugging facilities are gated behind the reasonably-named
ENABLE_DEBUGGING macro:

https://chromium.googlesource.com/chromium/deps/libsrtp/+/b17c065a8a63725eca2...

This code was imported to WebRTC from libjingle, but neither WebRTC or
Chromium ever set ENABLE_DEBUGGING. Even if someone had ever called
EnableSrtpDebugging, it wouldn't have done anything.

BUG=0
==========

to

==========
Remove useless debugging code

It would be enough to say we're removing EnableSrtpDebugging because
it's never called, but the story is a bit more interesting.

libsrtp's debugging facilities are gated behind the reasonably-named
ENABLE_DEBUGGING macro:

https://chromium.googlesource.com/chromium/deps/libsrtp/+/b17c065a8a63725eca2...

This code was imported to WebRTC from libjingle, but neither WebRTC or
Chromium ever set ENABLE_DEBUGGING. Even if someone had ever called
EnableSrtpDebugging, it wouldn't have done anything.

BUG=0
==========

[commit-bot: I haz the power, 2016-10-10 22:57:00]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-10 22:57:01]

Description was changed from

==========
Remove useless debugging code

It would be enough to say we're removing EnableSrtpDebugging because
it's never called, but the story is a bit more interesting.

libsrtp's debugging facilities are gated behind the reasonably-named
ENABLE_DEBUGGING macro:

https://chromium.googlesource.com/chromium/deps/libsrtp/+/b17c065a8a63725eca2...

This code was imported to WebRTC from libjingle, but neither WebRTC or
Chromium ever set ENABLE_DEBUGGING. Even if someone had ever called
EnableSrtpDebugging, it wouldn't have done anything.

BUG=0
==========

to

==========
Remove useless debugging code

It would be enough to say we're removing EnableSrtpDebugging because
it's never called, but the story is a bit more interesting.

libsrtp's debugging facilities are gated behind the reasonably-named
ENABLE_DEBUGGING macro:

https://chromium.googlesource.com/chromium/deps/libsrtp/+/b17c065a8a63725eca2...

This code was imported to WebRTC from libjingle, but neither WebRTC or
Chromium ever set ENABLE_DEBUGGING. Even if someone had ever called
EnableSrtpDebugging, it wouldn't have done anything.

BUG=0

Committed: https://crrev.com/8ff52cc7bc4e72f8967f15450aec30a6f766a3f5
Cr-Commit-Position: refs/heads/master@{#14592}
==========

[commit-bot: I haz the power, 2016-10-10 22:57:02]

Patchset 1 (id:??) landed as
https://crrev.com/8ff52cc7bc4e72f8967f15450aec30a6f766a3f5
Cr-Commit-Position: refs/heads/master@{#14592}