Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 2408983002: GN: Build iOS framework in build_ios_libs.sh (Closed)

Created:
4 years, 2 months ago by tkchin_webrtc
Modified:
4 years, 2 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

GN: Build iOS framework in build_ios_libs.sh BUG=webrtc:6372 NOTRY=True R=kjellander@webrtc.org Committed: https://crrev.com/dd0e1e007092a6a87a3abf994c69e0028229811c Cr-Commit-Position: refs/heads/master@{#14603}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update bundle version format. #

Patch Set 3 : Add check for provisioning file. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+187 lines, -30 lines) Patch
M webrtc/build/ios/build_ios_libs.sh View 1 2 1 chunk +176 lines, -30 lines 0 comments Download
M webrtc/sdk/BUILD.gn View 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
tkchin_webrtc
Another step forward. Restores framework build support and fixes a link issue. Still need to ...
4 years, 2 months ago (2016-10-10 23:57:48 UTC) #3
kjellander_webrtc
lgtm https://codereview.webrtc.org/2408983002/diff/1/webrtc/build/ios/build_ios_libs.sh File webrtc/build/ios/build_ios_libs.sh (right): https://codereview.webrtc.org/2408983002/diff/1/webrtc/build/ios/build_ios_libs.sh#newcode128 webrtc/build/ios/build_ios_libs.sh:128: exit 0 I'm thinking maybe it's a bit ...
4 years, 2 months ago (2016-10-11 04:04:30 UTC) #4
kthelgason
good stuff, lgtm!
4 years, 2 months ago (2016-10-11 14:15:28 UTC) #5
tkchin_webrtc
https://codereview.webrtc.org/2408983002/diff/1/webrtc/build/ios/build_ios_libs.sh File webrtc/build/ios/build_ios_libs.sh (right): https://codereview.webrtc.org/2408983002/diff/1/webrtc/build/ios/build_ios_libs.sh#newcode128 webrtc/build/ios/build_ios_libs.sh:128: exit 0 On 2016/10/11 04:04:30, kjellander_webrtc wrote: > I'm ...
4 years, 2 months ago (2016-10-11 18:17:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2408983002/20001
4 years, 2 months ago (2016-10-11 18:39:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2408983002/40001
4 years, 2 months ago (2016-10-11 19:03:33 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/9135)
4 years, 2 months ago (2016-10-11 19:20:43 UTC) #15
tkchin_webrtc
Committed patchset #3 (id:40001) manually as dd0e1e007092a6a87a3abf994c69e0028229811c (presubmit successful).
4 years, 2 months ago (2016-10-11 20:27:39 UTC) #17
tkchin_webrtc
4 years, 2 months ago (2016-10-11 20:28:24 UTC) #19
Message was sent while issue was closed.
On 2016/10/11 20:27:39, tkchin_webrtc wrote:
> Committed patchset #3 (id:40001) manually as
> dd0e1e007092a6a87a3abf994c69e0028229811c (presubmit successful).

Something bad happening with trybot presubmit so I ran presubmit locally and
committed manually.

Powered by Google App Engine
This is Rietveld 408576698