NetEq: Convert AverageIAT from int to float calculations

NetEq: Convert AverageIAT from int to float calculations

With this change, the calculations inside AverageIAT are changed to be
in double-precision floating point instead of in fixed point. Also,
the method's name is changed to EstimatedClockDriftPpm to better
reflect what it returns.

A few unit tests had to be updated because of minor numerical
differences.

Also removing the UBSan suppression related to this issue.

BUG=webrtc:5889
Committed: https://crrev.com/0d8385770b53f3fef11ed2f5d98af712dc2ba89d
Cr-Commit-Position: refs/heads/master@{#14628}

[hlundin-webrtc, 2016-10-10 11:13:35]

The CQ bit was checked by henrik.lundin@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-10 11:13:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[hlundin-webrtc, 2016-10-13 06:44:08]

henrik.lundin@webrtc.org changed reviewers:
+ kwiberg@webrtc.org

[hlundin-webrtc, 2016-10-13 06:44:08]

Karl, can you take a look at this CL?

The purpose is to provide an easy way out of a rare overflow happening in the
accumulation of the IAT vector.

[kwiberg-webrtc, 2016-10-13 08:30:24]

lgtm, but see comments.

https://codereview.webrtc.org/2408653002/diff/20001/webrtc/modules/audio_codi...
File webrtc/modules/audio_coding/neteq/delay_manager.cc (right):

https://codereview.webrtc.org/2408653002/diff/20001/webrtc/modules/audio_codi...
webrtc/modules/audio_coding/neteq/delay_manager.cc:331: return (sum / (1 << 30)
- 1) * 1000000;
Now that you use floating-point numbers, what's the point of multiplying by a
million?

Also, 1e6 is easier to read if you do decide to keep it.

Also, "subtract 1" -> "subtract the nominal inter-arrival time (1)" would make
this easier to understand.

[hlundin-webrtc, 2016-10-13 10:05:25]

https://codereview.webrtc.org/2408653002/diff/20001/webrtc/modules/audio_codi...
File webrtc/modules/audio_coding/neteq/delay_manager.cc (right):

https://codereview.webrtc.org/2408653002/diff/20001/webrtc/modules/audio_codi...
webrtc/modules/audio_coding/neteq/delay_manager.cc:331: return (sum / (1 << 30)
- 1) * 1000000;
On 2016/10/13 08:30:24, kwiberg-webrtc wrote:
> Now that you use floating-point numbers, what's the point of multiplying by a
> million?
To get ppm...?

> 
> Also, 1e6 is easier to read if you do decide to keep it.
Done.

> 
> Also, "subtract 1" -> "subtract the nominal inter-arrival time (1)" would make
> this easier to understand.
Done.

[hlundin-webrtc, 2016-10-13 10:05:30]

The CQ bit was checked by henrik.lundin@webrtc.org

[hlundin-webrtc, 2016-10-13 10:05:31]

The patchset sent to the CQ was uploaded after l-g-t-m from kwiberg@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2408653002/#ps40001 (title:
"Taking care of review comments")

[commit-bot: I haz the power, 2016-10-13 10:05:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-13 10:35:58]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-13 10:36:05]

Description was changed from

==========
NetEq: Convert AverageIAT from int to float calculations

With this change, the calculations inside AverageIAT are changed to be
in double-precision floating point instead of in fixed point. Also,
the method's name is changed to EstimatedClockDriftPpm to better
reflect what it returns.

A few unit tests had to be updated because of minor numerical
differences.

Also removing the UBSan suppression related to this issue.

BUG=webrtc:5889
==========

to

==========
NetEq: Convert AverageIAT from int to float calculations

With this change, the calculations inside AverageIAT are changed to be
in double-precision floating point instead of in fixed point. Also,
the method's name is changed to EstimatedClockDriftPpm to better
reflect what it returns.

A few unit tests had to be updated because of minor numerical
differences.

Also removing the UBSan suppression related to this issue.

BUG=webrtc:5889

Committed: https://crrev.com/0d8385770b53f3fef11ed2f5d98af712dc2ba89d
Cr-Commit-Position: refs/heads/master@{#14628}
==========

[commit-bot: I haz the power, 2016-10-13 10:36:06]

Patchset 3 (id:??) landed as
https://crrev.com/0d8385770b53f3fef11ed2f5d98af712dc2ba89d
Cr-Commit-Position: refs/heads/master@{#14628}