Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 2408153002: Remove cricket::VideoCodec with, height and framerate properties (Closed)

Created:
4 years, 2 months ago by perkj_webrtc
Modified:
4 years, 1 month ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove cricket::VideoCodec with, height and framerate properties Since WebRtcVideoSendStream have reconfigures the send codec to match the incoming captured frames widht and height they have not been used. Framerate has just been set when parsing sdp to 60fps and not changed elsewhere. This cl require some upstream projects to change first. BUG=webrtc:5332 Committed: https://crrev.com/267527459bd929a770278441493d4ec3da81de03 Cr-Commit-Position: refs/heads/master@{#14733}

Patch Set 1 #

Patch Set 2 : self review #

Patch Set 3 : rebased #

Total comments: 2

Patch Set 4 : Removed kDefaultVideoCodecFramerate from jsepsessiondescription.h #

Patch Set 5 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -413 lines) Patch
M webrtc/api/jsepsessiondescription.h View 1 2 3 1 chunk +0 lines, -5 lines 0 comments Download
M webrtc/api/jsepsessiondescription.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M webrtc/api/jsepsessiondescription_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/api/webrtcsdp.cc View 1 2 2 chunks +0 lines, -11 lines 0 comments Download
M webrtc/api/webrtcsdp_unittest.cc View 1 2 1 chunk +1 line, -4 lines 0 comments Download
M webrtc/media/base/codec.h View 1 2 1 chunk +0 lines, -9 lines 0 comments Download
M webrtc/media/base/codec.cc View 1 2 3 4 3 chunks +5 lines, -23 lines 0 comments Download
M webrtc/media/base/codec_unittest.cc View 1 2 3 4 9 chunks +27 lines, -37 lines 0 comments Download
M webrtc/media/base/fakemediaengine.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/media/base/mediaconstants.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/media/base/mediaconstants.cc View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M webrtc/media/base/videoengine_unittest.h View 1 2 21 chunks +47 lines, -205 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine2.cc View 1 2 3 4 3 chunks +3 lines, -9 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine2_unittest.cc View 1 2 3 4 28 chunks +53 lines, -72 lines 0 comments Download
M webrtc/pc/channel_unittest.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M webrtc/pc/channelmanager_unittest.cc View 1 2 2 chunks +2 lines, -3 lines 0 comments Download
M webrtc/pc/mediasession_unittest.cc View 3 chunks +7 lines, -10 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
perkj_webrtc
4 years, 2 months ago (2016-10-11 17:29:35 UTC) #3
pthatcher1
lgtm I love seeing this finally happen. https://codereview.webrtc.org/2408153002/diff/40001/webrtc/api/jsepsessiondescription.h File webrtc/api/jsepsessiondescription.h (right): https://codereview.webrtc.org/2408153002/diff/40001/webrtc/api/jsepsessiondescription.h#newcode70 webrtc/api/jsepsessiondescription.h:70: static const ...
4 years, 2 months ago (2016-10-13 21:33:47 UTC) #4
perkj_webrtc
https://codereview.webrtc.org/2408153002/diff/40001/webrtc/api/jsepsessiondescription.h File webrtc/api/jsepsessiondescription.h (right): https://codereview.webrtc.org/2408153002/diff/40001/webrtc/api/jsepsessiondescription.h#newcode70 webrtc/api/jsepsessiondescription.h:70: static const int kDefaultVideoCodecFramerate; On 2016/10/13 21:33:47, pthatcher1 wrote: ...
4 years, 2 months ago (2016-10-18 12:09:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2408153002/80001
4 years, 1 month ago (2016-10-24 07:13:27 UTC) #8
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 1 month ago (2016-10-24 08:21:21 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-10-24 08:21:28 UTC) #12
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/267527459bd929a770278441493d4ec3da81de03
Cr-Commit-Position: refs/heads/master@{#14733}

Powered by Google App Engine
This is Rietveld 408576698