| Index: webrtc/modules/video_coding/BUILD.gn
|
| diff --git a/webrtc/modules/video_coding/BUILD.gn b/webrtc/modules/video_coding/BUILD.gn
|
| index 45ff5a700485cbd53d504756a6903d9072abb7d5..4836207a9f202361f5dd12a3a83a634383fa7288 100644
|
| --- a/webrtc/modules/video_coding/BUILD.gn
|
| +++ b/webrtc/modules/video_coding/BUILD.gn
|
| @@ -77,9 +77,8 @@ rtc_static_library("video_coding") {
|
| # TODO(jschuh): Bug 1348: fix this warning.
|
| configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
|
|
|
| - if (is_clang) {
|
| - # Suppress warnings from Chrome's Clang plugins.
|
| - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
|
| + if (!build_with_chromium && is_clang) {
|
| + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
|
| suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
|
| }
|
|
|
| @@ -115,9 +114,8 @@ rtc_static_library("video_coding_utility") {
|
| "utility/vp8_header_parser.h",
|
| ]
|
|
|
| - if (is_clang) {
|
| - # Suppress warnings from Chrome's Clang plugins.
|
| - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
|
| + if (!build_with_chromium && is_clang) {
|
| + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
|
| suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
|
| }
|
|
|
| @@ -133,9 +131,8 @@ rtc_static_library("webrtc_h264") {
|
| "codecs/h264/include/h264.h",
|
| ]
|
|
|
| - if (is_clang) {
|
| - # Suppress warnings from Chrome's Clang plugins.
|
| - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
|
| + if (!build_with_chromium && is_clang) {
|
| + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
|
| suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
|
| }
|
|
|
| @@ -205,9 +202,8 @@ if (is_ios) {
|
| "VideoToolbox.framework",
|
| ]
|
|
|
| - if (is_clang) {
|
| - # Suppress warnings from Chrome's Clang plugins.
|
| - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
|
| + if (!build_with_chromium && is_clang) {
|
| + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
|
| suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
|
| }
|
|
|
| @@ -229,9 +225,8 @@ rtc_static_library("webrtc_i420") {
|
| "codecs/i420/include/i420.h",
|
| ]
|
|
|
| - if (is_clang) {
|
| - # Suppress warnings from Chrome's Clang plugins.
|
| - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
|
| + if (!build_with_chromium && is_clang) {
|
| + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
|
| suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
|
| }
|
|
|
| @@ -261,9 +256,8 @@ rtc_static_library("webrtc_vp8") {
|
| # TODO(jschuh): Bug 1348: fix this warning.
|
| configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
|
|
|
| - if (is_clang) {
|
| - # Suppress warnings from Chrome's Clang plugins.
|
| - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
|
| + if (!build_with_chromium && is_clang) {
|
| + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
|
| suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
|
| }
|
|
|
| @@ -295,9 +289,8 @@ rtc_static_library("webrtc_vp9") {
|
| ]
|
| }
|
|
|
| - if (is_clang) {
|
| - # Suppress warnings from Chrome's Clang plugins.
|
| - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
|
| + if (!build_with_chromium && is_clang) {
|
| + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
|
| suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
|
| }
|
|
|
| @@ -326,9 +319,8 @@ if (rtc_include_tests) {
|
| "codecs/test/videoprocessor.h",
|
| ]
|
|
|
| - if (is_clang) {
|
| - # Suppress warnings from Chrome's Clang plugins.
|
| - # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
|
| + if (!build_with_chromium && is_clang) {
|
| + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
|
| suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
|
| }
|
|
|
|
|