Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Side by Side Diff: webrtc/modules/video_processing/BUILD.gn

Issue 2408133008: GN: Exclude suppressions of Chromium Clang warnings for Chromium builds. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/modules/video_coding/BUILD.gn ('k') | webrtc/p2p/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved. 1 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
2 # 2 #
3 # Use of this source code is governed by a BSD-style license 3 # Use of this source code is governed by a BSD-style license
4 # that can be found in the LICENSE file in the root of the source 4 # that can be found in the LICENSE file in the root of the source
5 # tree. An additional intellectual property rights grant can be found 5 # tree. An additional intellectual property rights grant can be found
6 # in the file PATENTS. All contributing project authors may 6 # in the file PATENTS. All contributing project authors may
7 # be found in the AUTHORS file in the root of the source tree. 7 # be found in the AUTHORS file in the root of the source tree.
8 8
9 import("//build/config/arm.gni") 9 import("//build/config/arm.gni")
10 import("../../build/webrtc.gni") 10 import("../../build/webrtc.gni")
(...skipping 30 matching lines...) Expand all
41 "../../modules/utility", 41 "../../modules/utility",
42 "../../system_wrappers", 42 "../../system_wrappers",
43 ] 43 ]
44 if (build_video_processing_sse2) { 44 if (build_video_processing_sse2) {
45 deps += [ ":video_processing_sse2" ] 45 deps += [ ":video_processing_sse2" ]
46 } 46 }
47 if (rtc_build_with_neon) { 47 if (rtc_build_with_neon) {
48 deps += [ ":video_processing_neon" ] 48 deps += [ ":video_processing_neon" ]
49 } 49 }
50 50
51 if (is_clang) { 51 if (!build_with_chromium && is_clang) {
52 # Suppress warnings from Chrome's Clang plugins. 52 # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
53 # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
54 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] 53 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
55 } 54 }
56 } 55 }
57 56
58 if (build_video_processing_sse2) { 57 if (build_video_processing_sse2) {
59 rtc_static_library("video_processing_sse2") { 58 rtc_static_library("video_processing_sse2") {
60 sources = [ 59 sources = [
61 "util/denoiser_filter_sse2.cc", 60 "util/denoiser_filter_sse2.cc",
62 "util/denoiser_filter_sse2.h", 61 "util/denoiser_filter_sse2.h",
63 ] 62 ]
64 63
65 if (is_clang) { 64 if (!build_with_chromium && is_clang) {
66 # Suppress warnings from Chrome's Clang plugins. 65 # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
67 # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
68 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] 66 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
69 } 67 }
70 68
71 if (is_posix) { 69 if (is_posix) {
72 cflags = [ "-msse2" ] 70 cflags = [ "-msse2" ]
73 } 71 }
74 } 72 }
75 } 73 }
76 74
77 if (rtc_build_with_neon) { 75 if (rtc_build_with_neon) {
78 rtc_static_library("video_processing_neon") { 76 rtc_static_library("video_processing_neon") {
79 sources = [ 77 sources = [
80 "util/denoiser_filter_neon.cc", 78 "util/denoiser_filter_neon.cc",
81 "util/denoiser_filter_neon.h", 79 "util/denoiser_filter_neon.h",
82 ] 80 ]
83 if (current_cpu != "arm64") { 81 if (current_cpu != "arm64") {
84 suppressed_configs += [ "//build/config/compiler:compiler_arm_fpu" ] 82 suppressed_configs += [ "//build/config/compiler:compiler_arm_fpu" ]
85 cflags = [ "-mfpu=neon" ] 83 cflags = [ "-mfpu=neon" ]
86 } 84 }
87 } 85 }
88 } 86 }
OLDNEW
« no previous file with comments | « webrtc/modules/video_coding/BUILD.gn ('k') | webrtc/p2p/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698