Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Side by Side Diff: webrtc/modules/video_coding/BUILD.gn

Issue 2408133008: GN: Exclude suppressions of Chromium Clang warnings for Chromium builds. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/modules/video_capture/BUILD.gn ('k') | webrtc/modules/video_processing/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved. 1 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
2 # 2 #
3 # Use of this source code is governed by a BSD-style license 3 # Use of this source code is governed by a BSD-style license
4 # that can be found in the LICENSE file in the root of the source 4 # that can be found in the LICENSE file in the root of the source
5 # tree. An additional intellectual property rights grant can be found 5 # tree. An additional intellectual property rights grant can be found
6 # in the file PATENTS. All contributing project authors may 6 # in the file PATENTS. All contributing project authors may
7 # be found in the AUTHORS file in the root of the source tree. 7 # be found in the AUTHORS file in the root of the source tree.
8 8
9 import("../../build/webrtc.gni") 9 import("../../build/webrtc.gni")
10 10
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
70 "timing.h", 70 "timing.h",
71 "video_coding_impl.cc", 71 "video_coding_impl.cc",
72 "video_coding_impl.h", 72 "video_coding_impl.h",
73 "video_receiver.cc", 73 "video_receiver.cc",
74 "video_sender.cc", 74 "video_sender.cc",
75 ] 75 ]
76 76
77 # TODO(jschuh): Bug 1348: fix this warning. 77 # TODO(jschuh): Bug 1348: fix this warning.
78 configs += [ "//build/config/compiler:no_size_t_to_int_warning" ] 78 configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
79 79
80 if (is_clang) { 80 if (!build_with_chromium && is_clang) {
81 # Suppress warnings from Chrome's Clang plugins. 81 # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
82 # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
83 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] 82 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
84 } 83 }
85 84
86 deps = [ 85 deps = [
87 ":video_coding_utility", 86 ":video_coding_utility",
88 ":webrtc_h264", 87 ":webrtc_h264",
89 ":webrtc_i420", 88 ":webrtc_i420",
90 ":webrtc_vp8", 89 ":webrtc_vp8",
91 ":webrtc_vp9", 90 ":webrtc_vp9",
92 "../..:webrtc_common", 91 "../..:webrtc_common",
(...skipping 15 matching lines...) Expand all
108 "utility/qp_parser.cc", 107 "utility/qp_parser.cc",
109 "utility/qp_parser.h", 108 "utility/qp_parser.h",
110 "utility/quality_scaler.cc", 109 "utility/quality_scaler.cc",
111 "utility/quality_scaler.h", 110 "utility/quality_scaler.h",
112 "utility/simulcast_rate_allocator.cc", 111 "utility/simulcast_rate_allocator.cc",
113 "utility/simulcast_rate_allocator.h", 112 "utility/simulcast_rate_allocator.h",
114 "utility/vp8_header_parser.cc", 113 "utility/vp8_header_parser.cc",
115 "utility/vp8_header_parser.h", 114 "utility/vp8_header_parser.h",
116 ] 115 ]
117 116
118 if (is_clang) { 117 if (!build_with_chromium && is_clang) {
119 # Suppress warnings from Chrome's Clang plugins. 118 # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
120 # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
121 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] 119 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
122 } 120 }
123 121
124 deps = [ 122 deps = [
125 "../../common_video", 123 "../../common_video",
126 "../../system_wrappers", 124 "../../system_wrappers",
127 ] 125 ]
128 } 126 }
129 127
130 rtc_static_library("webrtc_h264") { 128 rtc_static_library("webrtc_h264") {
131 sources = [ 129 sources = [
132 "codecs/h264/h264.cc", 130 "codecs/h264/h264.cc",
133 "codecs/h264/include/h264.h", 131 "codecs/h264/include/h264.h",
134 ] 132 ]
135 133
136 if (is_clang) { 134 if (!build_with_chromium && is_clang) {
137 # Suppress warnings from Chrome's Clang plugins. 135 # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
138 # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
139 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] 136 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
140 } 137 }
141 138
142 defines = [] 139 defines = []
143 deps = [ 140 deps = [
144 "../../system_wrappers", 141 "../../system_wrappers",
145 ] 142 ]
146 143
147 if (is_ios) { 144 if (is_ios) {
148 sources += [ "codecs/h264/h264_objc.mm" ] 145 sources += [ "codecs/h264/h264_objc.mm" ]
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
198 "../../sdk:rtc_sdk_common_objc", 195 "../../sdk:rtc_sdk_common_objc",
199 ] 196 ]
200 197
201 libs = [ 198 libs = [
202 "CoreFoundation.framework", 199 "CoreFoundation.framework",
203 "CoreMedia.framework", 200 "CoreMedia.framework",
204 "CoreVideo.framework", 201 "CoreVideo.framework",
205 "VideoToolbox.framework", 202 "VideoToolbox.framework",
206 ] 203 ]
207 204
208 if (is_clang) { 205 if (!build_with_chromium && is_clang) {
209 # Suppress warnings from Chrome's Clang plugins. 206 # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
210 # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
211 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] 207 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
212 } 208 }
213 209
214 if (rtc_build_libyuv) { 210 if (rtc_build_libyuv) {
215 deps += [ "$rtc_libyuv_dir" ] 211 deps += [ "$rtc_libyuv_dir" ]
216 public_deps = [ 212 public_deps = [
217 "$rtc_libyuv_dir", 213 "$rtc_libyuv_dir",
218 ] 214 ]
219 } else { 215 } else {
220 # Need to add a directory normally exported by libyuv. 216 # Need to add a directory normally exported by libyuv.
221 include_dirs = [ "$rtc_libyuv_dir/include" ] 217 include_dirs = [ "$rtc_libyuv_dir/include" ]
222 } 218 }
223 } 219 }
224 } 220 }
225 221
226 rtc_static_library("webrtc_i420") { 222 rtc_static_library("webrtc_i420") {
227 sources = [ 223 sources = [
228 "codecs/i420/i420.cc", 224 "codecs/i420/i420.cc",
229 "codecs/i420/include/i420.h", 225 "codecs/i420/include/i420.h",
230 ] 226 ]
231 227
232 if (is_clang) { 228 if (!build_with_chromium && is_clang) {
233 # Suppress warnings from Chrome's Clang plugins. 229 # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
234 # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
235 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] 230 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
236 } 231 }
237 232
238 deps = [ 233 deps = [
239 "../../system_wrappers", 234 "../../system_wrappers",
240 ] 235 ]
241 } 236 }
242 237
243 rtc_static_library("webrtc_vp8") { 238 rtc_static_library("webrtc_vp8") {
244 sources = [ 239 sources = [
245 "codecs/vp8/default_temporal_layers.cc", 240 "codecs/vp8/default_temporal_layers.cc",
246 "codecs/vp8/default_temporal_layers.h", 241 "codecs/vp8/default_temporal_layers.h",
247 "codecs/vp8/include/vp8.h", 242 "codecs/vp8/include/vp8.h",
248 "codecs/vp8/include/vp8_common_types.h", 243 "codecs/vp8/include/vp8_common_types.h",
249 "codecs/vp8/realtime_temporal_layers.cc", 244 "codecs/vp8/realtime_temporal_layers.cc",
250 "codecs/vp8/reference_picture_selection.cc", 245 "codecs/vp8/reference_picture_selection.cc",
251 "codecs/vp8/reference_picture_selection.h", 246 "codecs/vp8/reference_picture_selection.h",
252 "codecs/vp8/screenshare_layers.cc", 247 "codecs/vp8/screenshare_layers.cc",
253 "codecs/vp8/screenshare_layers.h", 248 "codecs/vp8/screenshare_layers.h",
254 "codecs/vp8/simulcast_encoder_adapter.cc", 249 "codecs/vp8/simulcast_encoder_adapter.cc",
255 "codecs/vp8/simulcast_encoder_adapter.h", 250 "codecs/vp8/simulcast_encoder_adapter.h",
256 "codecs/vp8/temporal_layers.h", 251 "codecs/vp8/temporal_layers.h",
257 "codecs/vp8/vp8_impl.cc", 252 "codecs/vp8/vp8_impl.cc",
258 "codecs/vp8/vp8_impl.h", 253 "codecs/vp8/vp8_impl.h",
259 ] 254 ]
260 255
261 # TODO(jschuh): Bug 1348: fix this warning. 256 # TODO(jschuh): Bug 1348: fix this warning.
262 configs += [ "//build/config/compiler:no_size_t_to_int_warning" ] 257 configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
263 258
264 if (is_clang) { 259 if (!build_with_chromium && is_clang) {
265 # Suppress warnings from Chrome's Clang plugins. 260 # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
266 # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
267 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] 261 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
268 } 262 }
269 263
270 deps = [ 264 deps = [
271 ":video_coding_utility", 265 ":video_coding_utility",
272 "../..:webrtc_common", 266 "../..:webrtc_common",
273 "../../common_video", 267 "../../common_video",
274 "../../system_wrappers", 268 "../../system_wrappers",
275 ] 269 ]
276 if (rtc_build_libvpx) { 270 if (rtc_build_libvpx) {
(...skipping 11 matching lines...) Expand all
288 "codecs/vp9/vp9_frame_buffer_pool.h", 282 "codecs/vp9/vp9_frame_buffer_pool.h",
289 "codecs/vp9/vp9_impl.cc", 283 "codecs/vp9/vp9_impl.cc",
290 "codecs/vp9/vp9_impl.h", 284 "codecs/vp9/vp9_impl.h",
291 ] 285 ]
292 } else { 286 } else {
293 sources = [ 287 sources = [
294 "codecs/vp9/vp9_noop.cc", 288 "codecs/vp9/vp9_noop.cc",
295 ] 289 ]
296 } 290 }
297 291
298 if (is_clang) { 292 if (!build_with_chromium && is_clang) {
299 # Suppress warnings from Chrome's Clang plugins. 293 # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
300 # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
301 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] 294 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
302 } 295 }
303 296
304 deps = [ 297 deps = [
305 ":video_coding_utility", 298 ":video_coding_utility",
306 "../../common_video", 299 "../../common_video",
307 "../../system_wrappers", 300 "../../system_wrappers",
308 ] 301 ]
309 if (rtc_build_libvpx) { 302 if (rtc_build_libvpx) {
310 deps += [ rtc_libvpx_dir ] 303 deps += [ rtc_libvpx_dir ]
311 } 304 }
312 } 305 }
313 306
314 if (rtc_include_tests) { 307 if (rtc_include_tests) {
315 rtc_source_set("video_codecs_test_framework") { 308 rtc_source_set("video_codecs_test_framework") {
316 testonly = true 309 testonly = true
317 sources = [ 310 sources = [
318 "codecs/test/mock/mock_packet_manipulator.h", 311 "codecs/test/mock/mock_packet_manipulator.h",
319 "codecs/test/packet_manipulator.cc", 312 "codecs/test/packet_manipulator.cc",
320 "codecs/test/packet_manipulator.h", 313 "codecs/test/packet_manipulator.h",
321 "codecs/test/predictive_packet_manipulator.cc", 314 "codecs/test/predictive_packet_manipulator.cc",
322 "codecs/test/predictive_packet_manipulator.h", 315 "codecs/test/predictive_packet_manipulator.h",
323 "codecs/test/stats.cc", 316 "codecs/test/stats.cc",
324 "codecs/test/stats.h", 317 "codecs/test/stats.h",
325 "codecs/test/videoprocessor.cc", 318 "codecs/test/videoprocessor.cc",
326 "codecs/test/videoprocessor.h", 319 "codecs/test/videoprocessor.h",
327 ] 320 ]
328 321
329 if (is_clang) { 322 if (!build_with_chromium && is_clang) {
330 # Suppress warnings from Chrome's Clang plugins. 323 # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
331 # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
332 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] 324 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
333 } 325 }
334 326
335 deps = [ 327 deps = [
336 "../../test:test_support", 328 "../../test:test_support",
337 ] 329 ]
338 } 330 }
339 } 331 }
OLDNEW
« no previous file with comments | « webrtc/modules/video_capture/BUILD.gn ('k') | webrtc/modules/video_processing/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698