Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(731)

Side by Side Diff: webrtc/modules/BUILD.gn

Issue 2408133008: GN: Exclude suppressions of Chromium Clang warnings for Chromium builds. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/media/BUILD.gn ('k') | webrtc/modules/audio_coding/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 1 # Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
2 # 2 #
3 # Use of this source code is governed by a BSD-style license 3 # Use of this source code is governed by a BSD-style license
4 # that can be found in the LICENSE file in the root of the source 4 # that can be found in the LICENSE file in the root of the source
5 # tree. An additional intellectual property rights grant can be found 5 # tree. An additional intellectual property rights grant can be found
6 # in the file PATENTS. All contributing project authors may 6 # in the file PATENTS. All contributing project authors may
7 # be found in the AUTHORS file in the root of the source tree. 7 # be found in the AUTHORS file in the root of the source tree.
8 8
9 import("../build/webrtc.gni") 9 import("../build/webrtc.gni")
10 import("audio_coding/audio_coding.gni") 10 import("audio_coding/audio_coding.gni")
(...skipping 88 matching lines...) Expand 10 before | Expand all | Expand 10 after
99 99
100 if (is_android) { 100 if (is_android) {
101 deps += [ "//testing/android/native_test:native_test_native_code" ] 101 deps += [ "//testing/android/native_test:native_test_native_code" ]
102 shard_timeout = 900 102 shard_timeout = 900
103 } 103 }
104 104
105 if (is_ios) { 105 if (is_ios) {
106 deps += [ ":modules_tests_bundle_data" ] 106 deps += [ ":modules_tests_bundle_data" ]
107 } 107 }
108 108
109 if (is_clang) { 109 if (!build_with_chromium && is_clang) {
110 # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). 110 # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
111 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] 111 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
112 } 112 }
113 if (is_win) { 113 if (is_win) {
114 cflags = [ 114 cflags = [
115 # TODO(phoglund): get rid of 4373 supression when 115 # TODO(phoglund): get rid of 4373 supression when
116 # http://code.google.com/p/webrtc/issues/detail?id=261 is solved. 116 # http://code.google.com/p/webrtc/issues/detail?id=261 is solved.
117 # legacy warning for ignoring const / volatile in signatures. 117 # legacy warning for ignoring const / volatile in signatures.
118 "/wd4373", 118 "/wd4373",
119 ] 119 ]
(...skipping 131 matching lines...) Expand 10 before | Expand all | Expand 10 after
251 ] 251 ]
252 deps = [ 252 deps = [
253 "audio_coding:audio_network_adaptor", 253 "audio_coding:audio_network_adaptor",
254 "//testing/gmock", 254 "//testing/gmock",
255 "//testing/gtest", 255 "//testing/gtest",
256 ] 256 ]
257 if (rtc_enable_protobuf) { 257 if (rtc_enable_protobuf) {
258 deps += [ "audio_coding:ana_config_proto" ] 258 deps += [ "audio_coding:ana_config_proto" ]
259 defines = [ "WEBRTC_AUDIO_NETWORK_ADAPTOR_DEBUG_DUMP" ] 259 defines = [ "WEBRTC_AUDIO_NETWORK_ADAPTOR_DEBUG_DUMP" ]
260 } 260 }
261 if (is_clang) { 261 if (!build_with_chromium && is_clang) {
262 # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). 262 # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
263 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] 263 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
264 } 264 }
265 } 265 }
266 266
267 rtc_test("modules_unittests") { 267 rtc_test("modules_unittests") {
268 testonly = true 268 testonly = true
269 269
270 defines = audio_coding_defines 270 defines = audio_coding_defines
271 deps = [] 271 deps = []
(...skipping 328 matching lines...) Expand 10 before | Expand all | Expand 10 after
600 ] 600 ]
601 } 601 }
602 602
603 if (rtc_build_libvpx) { 603 if (rtc_build_libvpx) {
604 deps += [ rtc_libvpx_dir ] 604 deps += [ rtc_libvpx_dir ]
605 } 605 }
606 606
607 # TODO(jschuh): bugs.webrtc.org/1348: fix this warning. 607 # TODO(jschuh): bugs.webrtc.org/1348: fix this warning.
608 configs += [ "//build/config/compiler:no_size_t_to_int_warning" ] 608 configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
609 609
610 if (is_clang) { 610 if (!build_with_chromium && is_clang) {
611 # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). 611 # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
612 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] 612 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
613 } 613 }
614 614
615 if (is_win) { 615 if (is_win) {
616 cflags = [ 616 cflags = [
617 # TODO(kjellander): bugs.webrtc.org/261: Fix this warning. 617 # TODO(kjellander): bugs.webrtc.org/261: Fix this warning.
618 "/wd4373", # virtual function override. 618 "/wd4373", # virtual function override.
619 ] 619 ]
620 } 620 }
(...skipping 87 matching lines...) Expand 10 before | Expand all | Expand 10 after
708 } 708 }
709 709
710 rtc_test("bwe_simulator") { 710 rtc_test("bwe_simulator") {
711 testonly = true 711 testonly = true
712 712
713 deps = [] 713 deps = []
714 sources = [ 714 sources = [
715 "remote_bitrate_estimator/bwe_simulations.cc", 715 "remote_bitrate_estimator/bwe_simulations.cc",
716 ] 716 ]
717 717
718 if (is_clang) { 718 if (!build_with_chromium && is_clang) {
719 # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). 719 # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
720 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] 720 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
721 } 721 }
722 722
723 if (is_win) { 723 if (is_win) {
724 cflags = [ 724 cflags = [
725 # TODO(kjellander): bugs.webrtc.org/261: Fix this warning. 725 # TODO(kjellander): bugs.webrtc.org/261: Fix this warning.
726 "/wd4373", # virtual function override. 726 "/wd4373", # virtual function override.
727 ] 727 ]
728 } 728 }
729 729
730 deps += [ 730 deps += [
731 "..:webrtc_common", 731 "..:webrtc_common",
732 "../base:rtc_base_approved", 732 "../base:rtc_base_approved",
733 "../test:test_common", 733 "../test:test_common",
734 "../test:test_support_main", 734 "../test:test_support_main",
735 "remote_bitrate_estimator:bwe_simulator_lib", 735 "remote_bitrate_estimator:bwe_simulator_lib",
736 "video_capture", 736 "video_capture",
737 "//testing/gmock", 737 "//testing/gmock",
738 "//testing/gtest", 738 "//testing/gtest",
739 "//third_party/gflags", 739 "//third_party/gflags",
740 ] 740 ]
741 } 741 }
742 } 742 }
OLDNEW
« no previous file with comments | « webrtc/media/BUILD.gn ('k') | webrtc/modules/audio_coding/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698