Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Side by Side Diff: webrtc/libjingle/xmpp/BUILD.gn

Issue 2408133008: GN: Exclude suppressions of Chromium Clang warnings for Chromium builds. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/examples/BUILD.gn ('k') | webrtc/logging/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 1 # Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
2 # 2 #
3 # Use of this source code is governed by a BSD-style license 3 # Use of this source code is governed by a BSD-style license
4 # that can be found in the LICENSE file in the root of the source 4 # that can be found in the LICENSE file in the root of the source
5 # tree. An additional intellectual property rights grant can be found 5 # tree. An additional intellectual property rights grant can be found
6 # in the file PATENTS. All contributing project authors may 6 # in the file PATENTS. All contributing project authors may
7 # be found in the AUTHORS file in the root of the source tree. 7 # be found in the AUTHORS file in the root of the source tree.
8 8
9 import("../../build/webrtc.gni") 9 import("../../build/webrtc.gni")
10 10
(...skipping 121 matching lines...) Expand 10 before | Expand all | Expand 10 after
132 "xmppsocket.h", 132 "xmppsocket.h",
133 "xmppthread.cc", 133 "xmppthread.cc",
134 "xmppthread.h", 134 "xmppthread.h",
135 ] 135 ]
136 136
137 defines += [ 137 defines += [
138 "FEATURE_ENABLE_VOICEMAIL", 138 "FEATURE_ENABLE_VOICEMAIL",
139 "FEATURE_ENABLE_PSTN", 139 "FEATURE_ENABLE_PSTN",
140 ] 140 ]
141 141
142 if (is_clang) { 142 if (!build_with_chromium && is_clang) {
143 # Suppress warnings from Chrome's Clang plugins. 143 # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
144 # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
145 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] 144 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
146 } 145 }
147 } 146 }
148 147
149 if (is_posix && is_debug) { 148 if (is_posix && is_debug) {
150 # The Chromium build/common.gypi defines this for all posix 149 # The Chromium build/common.gypi defines this for all posix
151 # _except_ for ios & mac. We want it there as well, e.g. 150 # _except_ for ios & mac. We want it there as well, e.g.
152 # because ASSERT and friends trigger off of it. 151 # because ASSERT and friends trigger off of it.
153 defines += [ "_DEBUG" ] 152 defines += [ "_DEBUG" ]
154 } 153 }
155 } 154 }
OLDNEW
« no previous file with comments | « webrtc/examples/BUILD.gn ('k') | webrtc/logging/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698