Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 2407743002: Fix externalhmac.h/.cc to compile with libsrtp 1 and 2 (Closed)

Created:
4 years, 2 months ago by mattdr-at-webrtc.org
Modified:
4 years, 2 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, kjellander_webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix externalhmac.h/.cc to compile with libsrtp 1 and 2 This was missed in the first pass because this code only compiles in Chromium. BUG=webrtc:6376 Committed: https://crrev.com/8cab52db489b14552d6044232c215ab0420db4fc Cr-Commit-Position: refs/heads/master@{#14591}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -61 lines) Patch
M webrtc/pc/externalhmac.h View 3 chunks +31 lines, -18 lines 0 comments Download
M webrtc/pc/externalhmac.cc View 3 chunks +70 lines, -43 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
mattdr-at-webrtc.org
I verified this by changing the WebRTC build to bring in these two files and ...
4 years, 2 months ago (2016-10-10 03:52:40 UTC) #2
Taylor Brandstetter
lgtm
4 years, 2 months ago (2016-10-10 19:34:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2407743002/1
4 years, 2 months ago (2016-10-10 22:03:16 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-10 22:33:40 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-10 22:33:47 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8cab52db489b14552d6044232c215ab0420db4fc
Cr-Commit-Position: refs/heads/master@{#14591}

Powered by Google App Engine
This is Rietveld 408576698