Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(681)

Issue 2407163002: Make sure VideoReceiveStream can be restarted (Closed)

Created:
4 years, 2 months ago by sprang_webrtc
Modified:
4 years, 2 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, perkj_webrtc, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Make sure VideoReceiveStream can be restarted After calling Start(), doing a Stop() then Start() sequence should bring the stream back to the original state. BUG=webrtc:6501 Committed: https://crrev.com/113bdcadf37631835e65cd60d5d1f8d0926ba5f6 Cr-Commit-Position: refs/heads/master@{#14597}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -7 lines) Patch
M webrtc/video/end_to_end_tests.cc View 1 chunk +16 lines, -0 lines 0 comments Download
M webrtc/video/video_receive_stream.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/video/video_receive_stream.cc View 3 chunks +11 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sprang_webrtc
4 years, 2 months ago (2016-10-11 08:30:51 UTC) #2
tommi
lgtm
4 years, 2 months ago (2016-10-11 09:32:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2407163002/1
4 years, 2 months ago (2016-10-11 09:53:12 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-11 10:10:13 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 10:10:20 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/113bdcadf37631835e65cd60d5d1f8d0926ba5f6
Cr-Commit-Position: refs/heads/master@{#14597}

Powered by Google App Engine
This is Rietveld 408576698