Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(698)

Unified Diff: webrtc/modules/congestion_controller/delay_based_bwe.h

Issue 2407143002: Remove GetFeedbackInterval in sender side BWE. (Closed)
Patch Set: Rebased Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/congestion_controller/delay_based_bwe.h
diff --git a/webrtc/modules/congestion_controller/delay_based_bwe.h b/webrtc/modules/congestion_controller/delay_based_bwe.h
index 5ae60f7d21255480eb95fe2ebb65c64087f60434..57f089e9ec2a9928b5440dea9f0d0f4c64a424d2 100644
--- a/webrtc/modules/congestion_controller/delay_based_bwe.h
+++ b/webrtc/modules/congestion_controller/delay_based_bwe.h
@@ -79,16 +79,20 @@ class DelayBasedBwe {
float bitrate_estimate_var_;
RateStatistics old_estimator_;
const bool in_experiment_;
+ bool last_result_was_valid_;
};
- Result IncomingPacketFeedback(const PacketFeedback& packet_feedback);
+ void IncomingPacketFeedback(const PacketFeedback& packet_feedback);
Result OnLongFeedbackDelay(int64_t arrival_time_ms);
+
+ Result MaybeUpdateEstimate(bool overusing);
// Updates the current remote rate estimate and returns true if a valid
// estimate exists.
- bool UpdateEstimate(int64_t packet_arrival_time_ms,
- int64_t now_ms,
+ bool UpdateEstimate(int64_t now_ms,
rtc::Optional<uint32_t> acked_bitrate_bps,
- uint32_t* target_bitrate_bps);
+ bool overusing,
+ Result* result);
+
const bool in_trendline_experiment_;
const bool in_median_slope_experiment_;
@@ -101,7 +105,6 @@ class DelayBasedBwe {
std::unique_ptr<MedianSlopeEstimator> median_slope_estimator_;
OveruseDetector detector_;
BitrateEstimator receiver_incoming_bitrate_;
- int64_t last_update_ms_;
int64_t last_seen_packet_ms_;
bool uma_recorded_;
AimdRateControl rate_control_;

Powered by Google App Engine
This is Rietveld 408576698