Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Unified Diff: webrtc/modules/congestion_controller/delay_based_bwe_unittest.cc

Issue 2407143002: Remove GetFeedbackInterval in sender side BWE. (Closed)
Patch Set: Responsed to comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/congestion_controller/delay_based_bwe_unittest.cc
diff --git a/webrtc/modules/congestion_controller/delay_based_bwe_unittest.cc b/webrtc/modules/congestion_controller/delay_based_bwe_unittest.cc
index d4b3a72a3fdebab7e1db3d6dac917543518d3b0c..a8fb0c015780451be49550e03144d1fe360c2dea 100644
--- a/webrtc/modules/congestion_controller/delay_based_bwe_unittest.cc
+++ b/webrtc/modules/congestion_controller/delay_based_bwe_unittest.cc
@@ -119,26 +119,26 @@ TEST_F(DelayBasedBweTest, ProbeDetectionSlowerArrivalHighBitrate) {
TEST_F(DelayBasedBweTest, GetProbingInterval) {
int64_t default_interval_ms = bitrate_estimator_->GetProbingIntervalMs();
EXPECT_GT(default_interval_ms, 0);
- CapacityDropTestHelper(1, true, 567, 0);
+ CapacityDropTestHelper(1, true, 633, 0);
int64_t interval_ms = bitrate_estimator_->GetProbingIntervalMs();
EXPECT_GT(interval_ms, 0);
EXPECT_NE(interval_ms, default_interval_ms);
}
TEST_F(DelayBasedBweTest, InitialBehavior) {
- InitialBehaviorTestHelper(674840);
+ InitialBehaviorTestHelper(730000);
}
TEST_F(DelayBasedBweTest, RateIncreaseReordering) {
- RateIncreaseReorderingTestHelper(674840);
+ RateIncreaseReorderingTestHelper(730000);
}
TEST_F(DelayBasedBweTest, RateIncreaseRtpTimestamps) {
- RateIncreaseRtpTimestampsTestHelper(1240);
+ RateIncreaseRtpTimestampsTestHelper(612);
}
TEST_F(DelayBasedBweTest, CapacityDropOneStream) {
- CapacityDropTestHelper(1, false, 567, 0);
+ CapacityDropTestHelper(1, false, 633, 0);
}
TEST_F(DelayBasedBweTest, CapacityDropPosOffsetChange) {
@@ -146,11 +146,11 @@ TEST_F(DelayBasedBweTest, CapacityDropPosOffsetChange) {
}
TEST_F(DelayBasedBweTest, CapacityDropNegOffsetChange) {
- CapacityDropTestHelper(1, false, 733, -30000);
+ CapacityDropTestHelper(1, false, 367, -30000);
}
TEST_F(DelayBasedBweTest, CapacityDropOneStreamWrap) {
- CapacityDropTestHelper(1, true, 567, 0);
+ CapacityDropTestHelper(1, true, 633, 0);
}
TEST_F(DelayBasedBweTest, TestTimestampGrouping) {
@@ -184,11 +184,11 @@ class DelayBasedBweExperimentTest : public DelayBasedBweTest {
};
TEST_F(DelayBasedBweExperimentTest, RateIncreaseRtpTimestamps) {
- RateIncreaseRtpTimestampsTestHelper(1288);
+ RateIncreaseRtpTimestampsTestHelper(631);
}
TEST_F(DelayBasedBweExperimentTest, CapacityDropOneStream) {
- CapacityDropTestHelper(1, false, 333, 0);
+ CapacityDropTestHelper(1, false, 400, 0);
}
TEST_F(DelayBasedBweExperimentTest, CapacityDropPosOffsetChange) {
@@ -200,7 +200,7 @@ TEST_F(DelayBasedBweExperimentTest, CapacityDropNegOffsetChange) {
}
TEST_F(DelayBasedBweExperimentTest, CapacityDropOneStreamWrap) {
- CapacityDropTestHelper(1, true, 333, 0);
+ CapacityDropTestHelper(1, true, 400, 0);
}
class DelayBasedBweTrendlineExperimentTest : public DelayBasedBweTest {
@@ -215,23 +215,23 @@ class DelayBasedBweTrendlineExperimentTest : public DelayBasedBweTest {
};
TEST_F(DelayBasedBweTrendlineExperimentTest, RateIncreaseRtpTimestamps) {
- RateIncreaseRtpTimestampsTestHelper(1240);
+ RateIncreaseRtpTimestampsTestHelper(609);
}
TEST_F(DelayBasedBweTrendlineExperimentTest, CapacityDropOneStream) {
- CapacityDropTestHelper(1, false, 600, 0);
+ CapacityDropTestHelper(1, false, 700, 0);
}
TEST_F(DelayBasedBweTrendlineExperimentTest, CapacityDropPosOffsetChange) {
- CapacityDropTestHelper(1, false, 600, 30000);
+ CapacityDropTestHelper(1, false, 700, 30000);
}
TEST_F(DelayBasedBweTrendlineExperimentTest, CapacityDropNegOffsetChange) {
- CapacityDropTestHelper(1, false, 1267, -30000);
+ CapacityDropTestHelper(1, false, 767, -30000);
}
TEST_F(DelayBasedBweTrendlineExperimentTest, CapacityDropOneStreamWrap) {
- CapacityDropTestHelper(1, true, 600, 0);
+ CapacityDropTestHelper(1, true, 700, 0);
}
class DelayBasedBweMedianSlopeExperimentTest : public DelayBasedBweTest {
@@ -246,7 +246,7 @@ class DelayBasedBweMedianSlopeExperimentTest : public DelayBasedBweTest {
};
TEST_F(DelayBasedBweMedianSlopeExperimentTest, RateIncreaseRtpTimestamps) {
- RateIncreaseRtpTimestampsTestHelper(1240);
+ RateIncreaseRtpTimestampsTestHelper(609);
}
TEST_F(DelayBasedBweMedianSlopeExperimentTest, CapacityDropOneStream) {
@@ -254,11 +254,11 @@ TEST_F(DelayBasedBweMedianSlopeExperimentTest, CapacityDropOneStream) {
}
TEST_F(DelayBasedBweMedianSlopeExperimentTest, CapacityDropPosOffsetChange) {
- CapacityDropTestHelper(1, false, 600, 30000);
+ CapacityDropTestHelper(1, false, 700, 30000);
}
TEST_F(DelayBasedBweMedianSlopeExperimentTest, CapacityDropNegOffsetChange) {
- CapacityDropTestHelper(1, false, 1267, -30000);
+ CapacityDropTestHelper(1, false, 767, -30000);
}
TEST_F(DelayBasedBweMedianSlopeExperimentTest, CapacityDropOneStreamWrap) {

Powered by Google App Engine
This is Rietveld 408576698