webrtc/modules/congestion_controller/delay_based_bwe_unittest_helper.cc - Issue 2407143002: Remove GetFeedbackInterval in sender side BWE.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/congestion_controller/delay_based_bwe_unittest_helper.cc

Issue 2407143002: Remove GetFeedbackInterval in sender side BWE. (Closed)

Patch Set: rebased Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/modules/congestion_controller/delay_based_bwe.cc ('K') | « webrtc/modules/congestion_controller/delay_based_bwe_unittest.cc ('k') | webrtc/modules/remote_bitrate_estimator/aimd_rate_control.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/congestion_controller/delay_based_bwe_unittest_helper.cc

diff --git a/webrtc/modules/congestion_controller/delay_based_bwe_unittest_helper.cc b/webrtc/modules/congestion_controller/delay_based_bwe_unittest_helper.cc

index a3a1893cbe23811e4baed231423bf17947865ca6..0cc7c5edef49603ca44fffa464acb0fa9e20d36e 100644

--- a/webrtc/modules/congestion_controller/delay_based_bwe_unittest_helper.cc

+++ b/webrtc/modules/congestion_controller/delay_based_bwe_unittest_helper.cc

@@ -356,7 +356,7 @@ void DelayBasedBweTest::RateIncreaseRtpTimestampsTestHelper(

while (bitrate_bps < 5e5) {

bool overuse = GenerateAndProcessFrame(kDefaultSsrc, bitrate_bps);

if (overuse) {

- EXPECT_GT(bitrate_observer_.latest_bitrate(), bitrate_bps);

+ EXPECT_LT(bitrate_observer_.latest_bitrate(), bitrate_bps);

stefan-webrtc 2016/10/26 15:19:20 I don't really understand this expectation. I also

bitrate_bps = bitrate_observer_.latest_bitrate();

bitrate_observer_.Reset();

} else if (bitrate_observer_.updated()) {

@@ -374,7 +374,7 @@ void DelayBasedBweTest::CapacityDropTestHelper(

bool wrap_time_stamp,

uint32_t expected_bitrate_drop_delta,

int64_t receiver_clock_offset_change_ms) {

- const int kFramerate = 30;

+ const int kFramerate = 50;

stefan-webrtc 2016/10/26 15:19:20 Could you comment on this change?

const int kStartBitrate = 900e3;

const int kMinExpectedBitrate = 800e3;

const int kMaxExpectedBitrate = 1100e3;

@@ -407,7 +407,7 @@ void DelayBasedBweTest::CapacityDropTestHelper(

uint32_t bitrate_bps = SteadyStateRun(

kDefaultSsrc, steady_state_time * kFramerate, kStartBitrate,

kMinExpectedBitrate, kMaxExpectedBitrate, kInitialCapacityBps);

- EXPECT_NEAR(kInitialCapacityBps, bitrate_bps, 130000u);

+ EXPECT_NEAR(kInitialCapacityBps, bitrate_bps, 150000u);

bitrate_observer_.Reset();

// Add an offset to make sure the BWE can handle it.