Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Side by Side Diff: webrtc/modules/congestion_controller/delay_based_bwe_unittest.cc

Issue 2407143002: Remove GetFeedbackInterval in sender side BWE. (Closed)
Patch Set: Solve issue with delayed_feedback. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 108 matching lines...) Expand 10 before | Expand all | Expand 10 after
119 TEST_F(DelayBasedBweTest, GetProbingInterval) { 119 TEST_F(DelayBasedBweTest, GetProbingInterval) {
120 int64_t default_interval_ms = bitrate_estimator_->GetProbingIntervalMs(); 120 int64_t default_interval_ms = bitrate_estimator_->GetProbingIntervalMs();
121 EXPECT_GT(default_interval_ms, 0); 121 EXPECT_GT(default_interval_ms, 0);
122 CapacityDropTestHelper(1, true, 333, 0); 122 CapacityDropTestHelper(1, true, 333, 0);
123 int64_t interval_ms = bitrate_estimator_->GetProbingIntervalMs(); 123 int64_t interval_ms = bitrate_estimator_->GetProbingIntervalMs();
124 EXPECT_GT(interval_ms, 0); 124 EXPECT_GT(interval_ms, 0);
125 EXPECT_NE(interval_ms, default_interval_ms); 125 EXPECT_NE(interval_ms, default_interval_ms);
126 } 126 }
127 127
128 TEST_F(DelayBasedBweTest, InitialBehavior) { 128 TEST_F(DelayBasedBweTest, InitialBehavior) {
129 InitialBehaviorTestHelper(674840); 129 InitialBehaviorTestHelper(730000);
130 } 130 }
131 131
132 TEST_F(DelayBasedBweTest, RateIncreaseReordering) { 132 TEST_F(DelayBasedBweTest, RateIncreaseReordering) {
133 RateIncreaseReorderingTestHelper(674840); 133 RateIncreaseReorderingTestHelper(730000);
134 } 134 }
135 TEST_F(DelayBasedBweTest, RateIncreaseRtpTimestamps) { 135 TEST_F(DelayBasedBweTest, RateIncreaseRtpTimestamps) {
136 RateIncreaseRtpTimestampsTestHelper(1288); 136 RateIncreaseRtpTimestampsTestHelper(627);
137 } 137 }
138 138
139 TEST_F(DelayBasedBweTest, CapacityDropOneStream) { 139 TEST_F(DelayBasedBweTest, CapacityDropOneStream) {
140 CapacityDropTestHelper(1, false, 333, 0); 140 CapacityDropTestHelper(1, false, 300, 0);
141 } 141 }
142 142
143 TEST_F(DelayBasedBweTest, CapacityDropPosOffsetChange) { 143 TEST_F(DelayBasedBweTest, CapacityDropPosOffsetChange) {
144 CapacityDropTestHelper(1, false, 867, 30000); 144 CapacityDropTestHelper(1, false, 867, 30000);
145 } 145 }
146 146
147 TEST_F(DelayBasedBweTest, CapacityDropNegOffsetChange) { 147 TEST_F(DelayBasedBweTest, CapacityDropNegOffsetChange) {
148 CapacityDropTestHelper(1, false, 867, -30000); 148 CapacityDropTestHelper(1, false, 933, -30000);
149 } 149 }
150 150
151 TEST_F(DelayBasedBweTest, CapacityDropOneStreamWrap) { 151 TEST_F(DelayBasedBweTest, CapacityDropOneStreamWrap) {
152 CapacityDropTestHelper(1, true, 333, 0); 152 CapacityDropTestHelper(1, true, 333, 0);
153 } 153 }
154
154 TEST_F(DelayBasedBweTest, TestTimestampGrouping) { 155 TEST_F(DelayBasedBweTest, TestTimestampGrouping) {
155 TestTimestampGroupingTestHelper(); 156 TestTimestampGroupingTestHelper();
156 } 157 }
157 158
158 TEST_F(DelayBasedBweTest, TestShortTimeoutAndWrap) { 159 TEST_F(DelayBasedBweTest, TestShortTimeoutAndWrap) {
159 // Simulate a client leaving and rejoining the call after 35 seconds. This 160 // Simulate a client leaving and rejoining the call after 35 seconds. This
160 // will make abs send time wrap, so if streams aren't timed out properly 161 // will make abs send time wrap, so if streams aren't timed out properly
161 // the next 30 seconds of packets will be out of order. 162 // the next 30 seconds of packets will be out of order.
162 TestWrappingHelper(35); 163 TestWrappingHelper(35);
163 } 164 }
164 165
165 TEST_F(DelayBasedBweTest, TestLongTimeoutAndWrap) { 166 TEST_F(DelayBasedBweTest, TestLongTimeoutAndWrap) {
166 // Simulate a client leaving and rejoining the call after some multiple of 167 // Simulate a client leaving and rejoining the call after some multiple of
167 // 64 seconds later. This will cause a zero difference in abs send times due 168 // 64 seconds later. This will cause a zero difference in abs send times due
168 // to the wrap, but a big difference in arrival time, if streams aren't 169 // to the wrap, but a big difference in arrival time, if streams aren't
169 // properly timed out. 170 // properly timed out.
170 TestWrappingHelper(10 * 64); 171 TestWrappingHelper(10 * 64);
171 } 172 }
172 173
173 } // namespace webrtc 174 } // namespace webrtc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698