Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Side by Side Diff: webrtc/modules/congestion_controller/delay_based_bwe.h

Issue 2407143002: Remove GetFeedbackInterval in sender side BWE. (Closed)
Patch Set: Rebased Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
72 72
73 private: 73 private:
74 float UpdateWindow(int64_t now_ms, int bytes, int rate_window_ms); 74 float UpdateWindow(int64_t now_ms, int bytes, int rate_window_ms);
75 int sum_; 75 int sum_;
76 int64_t current_win_ms_; 76 int64_t current_win_ms_;
77 int64_t prev_time_ms_; 77 int64_t prev_time_ms_;
78 float bitrate_estimate_; 78 float bitrate_estimate_;
79 float bitrate_estimate_var_; 79 float bitrate_estimate_var_;
80 RateStatistics old_estimator_; 80 RateStatistics old_estimator_;
81 const bool in_experiment_; 81 const bool in_experiment_;
82 bool last_result_was_valid_;
82 }; 83 };
83 84
84 Result IncomingPacketFeedback(const PacketFeedback& packet_feedback); 85 void IncomingPacketFeedback(const PacketFeedback& packet_feedback);
85 Result OnLongFeedbackDelay(int64_t arrival_time_ms); 86 Result OnLongFeedbackDelay(int64_t arrival_time_ms);
87
88 Result MaybeUpdateEstimate(bool overusing);
86 // Updates the current remote rate estimate and returns true if a valid 89 // Updates the current remote rate estimate and returns true if a valid
87 // estimate exists. 90 // estimate exists.
88 bool UpdateEstimate(int64_t packet_arrival_time_ms, 91 bool UpdateEstimate(int64_t now_ms,
89 int64_t now_ms,
90 rtc::Optional<uint32_t> acked_bitrate_bps, 92 rtc::Optional<uint32_t> acked_bitrate_bps,
91 uint32_t* target_bitrate_bps); 93 bool overusing,
94 Result* result);
95
92 const bool in_trendline_experiment_; 96 const bool in_trendline_experiment_;
93 const bool in_median_slope_experiment_; 97 const bool in_median_slope_experiment_;
94 98
95 rtc::ThreadChecker network_thread_; 99 rtc::ThreadChecker network_thread_;
96 RtcEventLog* const event_log_; 100 RtcEventLog* const event_log_;
97 const Clock* const clock_; 101 const Clock* const clock_;
98 std::unique_ptr<InterArrival> inter_arrival_; 102 std::unique_ptr<InterArrival> inter_arrival_;
99 std::unique_ptr<OveruseEstimator> kalman_estimator_; 103 std::unique_ptr<OveruseEstimator> kalman_estimator_;
100 std::unique_ptr<TrendlineEstimator> trendline_estimator_; 104 std::unique_ptr<TrendlineEstimator> trendline_estimator_;
101 std::unique_ptr<MedianSlopeEstimator> median_slope_estimator_; 105 std::unique_ptr<MedianSlopeEstimator> median_slope_estimator_;
102 OveruseDetector detector_; 106 OveruseDetector detector_;
103 BitrateEstimator receiver_incoming_bitrate_; 107 BitrateEstimator receiver_incoming_bitrate_;
104 int64_t last_update_ms_;
105 int64_t last_seen_packet_ms_; 108 int64_t last_seen_packet_ms_;
106 bool uma_recorded_; 109 bool uma_recorded_;
107 AimdRateControl rate_control_; 110 AimdRateControl rate_control_;
108 ProbeBitrateEstimator probe_bitrate_estimator_; 111 ProbeBitrateEstimator probe_bitrate_estimator_;
109 size_t trendline_window_size_; 112 size_t trendline_window_size_;
110 double trendline_smoothing_coeff_; 113 double trendline_smoothing_coeff_;
111 double trendline_threshold_gain_; 114 double trendline_threshold_gain_;
112 ProbingIntervalEstimator probing_interval_estimator_; 115 ProbingIntervalEstimator probing_interval_estimator_;
113 size_t median_slope_window_size_; 116 size_t median_slope_window_size_;
114 double median_slope_threshold_gain_; 117 double median_slope_threshold_gain_;
115 int consecutive_delayed_feedbacks_; 118 int consecutive_delayed_feedbacks_;
116 uint32_t last_logged_bitrate_; 119 uint32_t last_logged_bitrate_;
117 BandwidthUsage last_logged_state_; 120 BandwidthUsage last_logged_state_;
118 121
119 RTC_DISALLOW_IMPLICIT_CONSTRUCTORS(DelayBasedBwe); 122 RTC_DISALLOW_IMPLICIT_CONSTRUCTORS(DelayBasedBwe);
120 }; 123 };
121 124
122 } // namespace webrtc 125 } // namespace webrtc
123 126
124 #endif // WEBRTC_MODULES_CONGESTION_CONTROLLER_DELAY_BASED_BWE_H_ 127 #endif // WEBRTC_MODULES_CONGESTION_CONTROLLER_DELAY_BASED_BWE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698