Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(720)

Side by Side Diff: webrtc/modules/congestion_controller/delay_based_bwe.h

Issue 2407143002: Remove GetFeedbackInterval in sender side BWE. (Closed)
Patch Set: Responsed to comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
69 69
70 private: 70 private:
71 float UpdateWindow(int64_t now_ms, int bytes, int rate_window_ms); 71 float UpdateWindow(int64_t now_ms, int bytes, int rate_window_ms);
72 int sum_; 72 int sum_;
73 int64_t current_win_ms_; 73 int64_t current_win_ms_;
74 int64_t prev_time_ms_; 74 int64_t prev_time_ms_;
75 float bitrate_estimate_; 75 float bitrate_estimate_;
76 float bitrate_estimate_var_; 76 float bitrate_estimate_var_;
77 RateStatistics old_estimator_; 77 RateStatistics old_estimator_;
78 const bool in_experiment_; 78 const bool in_experiment_;
79 bool last_result_was_valid_;
79 }; 80 };
80 81
81 Result IncomingPacketInfo(const PacketInfo& info); 82 Result IncomingPacketInfo(const PacketInfo& info);
83
84 void MaybeUpdateEstimate(Result* result);
82 // Updates the current remote rate estimate and returns true if a valid 85 // Updates the current remote rate estimate and returns true if a valid
83 // estimate exists. 86 // estimate exists.
84 bool UpdateEstimate(int64_t packet_arrival_time_ms, 87 bool UpdateEstimate(int64_t now_ms,
85 int64_t now_ms,
86 rtc::Optional<uint32_t> acked_bitrate_bps, 88 rtc::Optional<uint32_t> acked_bitrate_bps,
87 uint32_t* target_bitrate_bps); 89 uint32_t* target_bitrate_bps);
88 const bool in_trendline_experiment_; 90 const bool in_trendline_experiment_;
89 const bool in_median_slope_experiment_; 91 const bool in_median_slope_experiment_;
90 92
91 rtc::ThreadChecker network_thread_; 93 rtc::ThreadChecker network_thread_;
92 Clock* const clock_; 94 Clock* const clock_;
93 std::unique_ptr<InterArrival> inter_arrival_; 95 std::unique_ptr<InterArrival> inter_arrival_;
94 std::unique_ptr<OveruseEstimator> kalman_estimator_; 96 std::unique_ptr<OveruseEstimator> kalman_estimator_;
95 std::unique_ptr<TrendlineEstimator> trendline_estimator_; 97 std::unique_ptr<TrendlineEstimator> trendline_estimator_;
96 std::unique_ptr<MedianSlopeEstimator> median_slope_estimator_; 98 std::unique_ptr<MedianSlopeEstimator> median_slope_estimator_;
97 OveruseDetector detector_; 99 OveruseDetector detector_;
98 BitrateEstimator receiver_incoming_bitrate_; 100 BitrateEstimator receiver_incoming_bitrate_;
99 int64_t last_update_ms_;
100 int64_t last_seen_packet_ms_; 101 int64_t last_seen_packet_ms_;
101 bool uma_recorded_; 102 bool uma_recorded_;
102 AimdRateControl rate_control_; 103 AimdRateControl rate_control_;
103 ProbeBitrateEstimator probe_bitrate_estimator_; 104 ProbeBitrateEstimator probe_bitrate_estimator_;
104 size_t trendline_window_size_; 105 size_t trendline_window_size_;
105 double trendline_smoothing_coeff_; 106 double trendline_smoothing_coeff_;
106 double trendline_threshold_gain_; 107 double trendline_threshold_gain_;
107 ProbingIntervalEstimator probing_interval_estimator_; 108 ProbingIntervalEstimator probing_interval_estimator_;
108 size_t median_slope_window_size_; 109 size_t median_slope_window_size_;
109 double median_slope_threshold_gain_; 110 double median_slope_threshold_gain_;
110 111
111 RTC_DISALLOW_IMPLICIT_CONSTRUCTORS(DelayBasedBwe); 112 RTC_DISALLOW_IMPLICIT_CONSTRUCTORS(DelayBasedBwe);
112 }; 113 };
113 114
114 } // namespace webrtc 115 } // namespace webrtc
115 116
116 #endif // WEBRTC_MODULES_CONGESTION_CONTROLLER_DELAY_BASED_BWE_H_ 117 #endif // WEBRTC_MODULES_CONGESTION_CONTROLLER_DELAY_BASED_BWE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698