Remove GetFeedbackInterval in sender side BWE.

webrtc/modules/remote_bitrate_estimator/aimd_rate_control.cc

 /*
  *  Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 #include "webrtc/modules/remote_bitrate_estimator/aimd_rate_control.h"
 
 #include <algorithm>
 #include <cassert>
 #include <cmath>
 
 #include "webrtc/base/checks.h"
 
 #include "webrtc/modules/remote_bitrate_estimator/overuse_detector.h"
 #include "webrtc/modules/remote_bitrate_estimator/include/remote_bitrate_estimator.h"
 #include "webrtc/modules/remote_bitrate_estimator/test/bwe_test_logging.h"
 
 namespace webrtc {
 
-static const int64_t kDefaultRttMs = 200;
-static const double kWithinIncomingBitrateHysteresis = 1.05;
-static const int64_t kMaxFeedbackIntervalMs = 1000;
+namespace {
+constexpr int64_t kDefaultRttMs = 200;
+constexpr double kWithinIncomingBitrateHysteresis = 1.05;
+constexpr int64_t kMaxFeedbackIntervalMs = 1000;
+constexpr double kMinIncreaseBps = 250.0;
+}  // namespace
 
 AimdRateControl::AimdRateControl()
     : min_configured_bitrate_bps_(
           RemoteBitrateEstimator::kDefaultMinBitrateBps),
       max_configured_bitrate_bps_(30000000),
       current_bitrate_bps_(max_configured_bitrate_bps_),
       avg_max_bitrate_kbps_(-1.0f),
       var_max_bitrate_kbps_(0.4f),
       rate_control_state_(kRcHold),
       rate_control_region_(kRcMaxUnknown),
@@ skipping 184 matching lines @@
 }
 
 uint32_t AimdRateControl::MultiplicativeRateIncrease(
     int64_t now_ms, int64_t last_ms, uint32_t current_bitrate_bps) const {
   double alpha = 1.08;
   if (last_ms > -1) {
     int time_since_last_update_ms = std::min(static_cast<int>(now_ms - last_ms),
                                              1000);
     alpha = pow(alpha,  time_since_last_update_ms / 1000.0);
   }
-  uint32_t multiplicative_increase_bps = std::max(
-      current_bitrate_bps * (alpha - 1.0), 1000.0);
+  uint32_t multiplicative_increase_bps =
+      std::max(current_bitrate_bps * (alpha - 1.0), kMinIncreaseBps);
   return multiplicative_increase_bps;
 }
 
 uint32_t AimdRateControl::AdditiveRateIncrease(
     int64_t now_ms, int64_t last_ms, int64_t response_time_ms) const {
   assert(response_time_ms > 0);
   double beta = 0.0;
   if (last_ms > 0) {
     beta = std::min((now_ms - last_ms) / static_cast<double>(response_time_ms),
                     1.0);
     if (in_experiment_)
       beta /= 2.0;
   }
   double bits_per_frame = static_cast<double>(current_bitrate_bps_) / 30.0;
   double packets_per_frame = std::ceil(bits_per_frame / (8.0 * 1200.0));
   double avg_packet_size_bits = bits_per_frame / packets_per_frame;
-  uint32_t additive_increase_bps = std::max(
-      1000.0, beta * avg_packet_size_bits);
+  uint32_t additive_increase_bps =
+      std::max(kMinIncreaseBps, beta * avg_packet_size_bits);
   return additive_increase_bps;
 }
 
 void AimdRateControl::UpdateMaxBitRateEstimate(float incoming_bitrate_kbps) {
   const float alpha = 0.05f;
   if (avg_max_bitrate_kbps_ == -1.0f) {
     avg_max_bitrate_kbps_ = incoming_bitrate_kbps;
   } else {
     avg_max_bitrate_kbps_ = (1 - alpha) * avg_max_bitrate_kbps_ +
         alpha * incoming_bitrate_kbps;
@@ skipping 37 matching lines @@
 }
 
 void AimdRateControl::ChangeRegion(RateControlRegion region) {
   rate_control_region_ = region;
 }
 
 void AimdRateControl::ChangeState(RateControlState new_state) {
   rate_control_state_ = new_state;
 }
 }  // namespace webrtc