Add unittest for I420Buffer::Rotate.

Add unittest for I420Buffer::Rotate.

Also change pointer to const ref for CheckCrop helper.

BUG=webrtc:5682
Committed: https://crrev.com/f33970b15e0eeb46548fa602f6d0c1fcfd44dd19
Cr-Commit-Position: refs/heads/master@{#14663}

[nisse-webrtc, 2016-10-07 14:28:05]

nisse@webrtc.org changed reviewers:
+ magjed@webrtc.org, perkj@webrtc.org

[nisse-webrtc, 2016-10-07 14:28:06]

PTAL.

[perkj_webrtc, 2016-10-09 18:13:44]

thanks
lgtm with a nit.

https://codereview.webrtc.org/2406463002/diff/1/webrtc/common_video/i420_vide...
File webrtc/common_video/i420_video_frame_unittest.cc (right):

https://codereview.webrtc.org/2406463002/diff/1/webrtc/common_video/i420_vide...
webrtc/common_video/i420_video_frame_unittest.cc:87: EXPECT_EQ(rotated.width(),
rotated_width);
nit, expect orders. Put the expectation as the first argument and what you check
in the second. And yes, its the opposite for EXPECT_GT etc.

[magjed_webrtc, 2016-10-13 22:35:12]

https://codereview.webrtc.org/2406463002/diff/20001/webrtc/common_video/i420_...
File webrtc/common_video/i420_video_frame_unittest.cc (right):

https://codereview.webrtc.org/2406463002/diff/20001/webrtc/common_video/i420_...
webrtc/common_video/i420_video_frame_unittest.cc:354: TEST(TestI420FrameBuffer,
Rotate_0) {
Can you turn this into a parameterized test (TEST_P) with arguments
kVideoRotation_0, kVideoRotation_90, kVideoRotation_180, kVideoRotation_270
instead?

[nisse-webrtc, 2016-10-18 09:34:21]

https://codereview.webrtc.org/2406463002/diff/1/webrtc/common_video/i420_vide...
File webrtc/common_video/i420_video_frame_unittest.cc (right):

https://codereview.webrtc.org/2406463002/diff/1/webrtc/common_video/i420_vide...
webrtc/common_video/i420_video_frame_unittest.cc:87: EXPECT_EQ(rotated.width(),
rotated_width);
On 2016/10/09 18:13:44, perkj_webrtc wrote:
> nit, expect orders. Put the expectation as the first argument and what you
check
> in the second. And yes, its the opposite for EXPECT_GT etc.

Done.

https://codereview.webrtc.org/2406463002/diff/20001/webrtc/common_video/i420_...
File webrtc/common_video/i420_video_frame_unittest.cc (right):

https://codereview.webrtc.org/2406463002/diff/20001/webrtc/common_video/i420_...
webrtc/common_video/i420_video_frame_unittest.cc:354: TEST(TestI420FrameBuffer,
Rotate_0) {
On 2016/10/13 22:35:11, magjed_webrtc wrote:
> Can you turn this into a parameterized test (TEST_P) with arguments
> kVideoRotation_0, kVideoRotation_90, kVideoRotation_180, kVideoRotation_270
> instead?

Done.

[magjed_webrtc, 2016-10-18 12:22:05]

lgtm

[nisse-webrtc, 2016-10-18 12:25:11]

The CQ bit was checked by nisse@webrtc.org

[nisse-webrtc, 2016-10-18 12:25:12]

The patchset sent to the CQ was uploaded after l-g-t-m from perkj@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2406463002/#ps40001 (title:
"Use parameterized test.")

[commit-bot: I haz the power, 2016-10-18 12:25:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-18 13:01:37]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-18 13:01:43]

Description was changed from

==========
Add unittest for I420Buffer::Rotate.

Also change pointer to const ref for CheckCrop helper.

BUG=webrtc:5682
==========

to

==========
Add unittest for I420Buffer::Rotate.

Also change pointer to const ref for CheckCrop helper.

BUG=webrtc:5682

Committed: https://crrev.com/f33970b15e0eeb46548fa602f6d0c1fcfd44dd19
Cr-Commit-Position: refs/heads/master@{#14663}
==========

[commit-bot: I haz the power, 2016-10-18 13:01:44]

Patchset 3 (id:??) landed as
https://crrev.com/f33970b15e0eeb46548fa602f6d0c1fcfd44dd19
Cr-Commit-Position: refs/heads/master@{#14663}