Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Side by Side Diff: webrtc/api/call/audio_send_stream.h

Issue 2405183002: Moving WebRtcVoiceMediaChannel::SendSetCodec to AudioSendStream. (Closed)
Patch Set: adding logs and addressing some earlier comments. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | webrtc/audio/audio_send_stream.h » ('j') | webrtc/audio/audio_send_stream.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
80 // Underlying VoiceEngine handle, used to map AudioSendStream to lower-level 80 // Underlying VoiceEngine handle, used to map AudioSendStream to lower-level
81 // components. 81 // components.
82 // TODO(solenberg): Remove when VoiceEngine channels are created outside 82 // TODO(solenberg): Remove when VoiceEngine channels are created outside
83 // of Call. 83 // of Call.
84 int voe_channel_id = -1; 84 int voe_channel_id = -1;
85 85
86 // Ownership of the encoder object is transferred to Call when the config is 86 // Ownership of the encoder object is transferred to Call when the config is
87 // passed to Call::CreateAudioSendStream(). 87 // passed to Call::CreateAudioSendStream().
88 // TODO(solenberg): Implement, once we configure codecs through the new API. 88 // TODO(solenberg): Implement, once we configure codecs through the new API.
89 // std::unique_ptr<AudioEncoder> encoder; 89 // std::unique_ptr<AudioEncoder> encoder;
90 int cng_payload_type = -1; // pt, or -1 to disable Comfort Noise Generator. 90 int cng_payload_type = -1; // pt, or -1 to disable Comfort Noise Generator.
minyue-webrtc 2016/10/18 09:39:00 I found this to be duplicate of SendCodecSpec::cng
91 91
92 // Bitrate limits used for variable audio bitrate streams. Set both to -1 to 92 // Bitrate limits used for variable audio bitrate streams. Set both to -1 to
93 // disable audio bitrate adaptation. 93 // disable audio bitrate adaptation.
94 // Note: This is still an experimental feature and not ready for real usage. 94 // Note: This is still an experimental feature and not ready for real usage.
95 int min_bitrate_kbps = -1; 95 int min_bitrate_kbps = -1;
96 int max_bitrate_kbps = -1; 96 int max_bitrate_kbps = -1;
97
98 struct SendCodecSpec {
99 SendCodecSpec() {
100 webrtc::CodecInst empty_inst = {0};
101 codec_inst = empty_inst;
102 codec_inst.pltype = -1;
103 }
104 bool operator==(const SendCodecSpec& rhs) const {
105 {
106 if (nack_enabled != rhs.nack_enabled) {
107 return false;
108 }
109 if (transport_cc_enabled != rhs.transport_cc_enabled) {
110 return false;
111 }
112 if (enable_codec_fec != rhs.enable_codec_fec) {
113 return false;
114 }
115 if (enable_opus_dtx != rhs.enable_opus_dtx) {
116 return false;
117 }
118 if (opus_max_playback_rate != rhs.opus_max_playback_rate) {
119 return false;
120 }
121 if (red_payload_type != rhs.red_payload_type) {
122 return false;
123 }
124 if (cng_payload_type != rhs.cng_payload_type) {
125 return false;
126 }
127 if (cng_plfreq != rhs.cng_plfreq) {
128 return false;
129 }
130 if (codec_inst != rhs.codec_inst) {
131 return false;
132 }
133 return true;
134 }
135 }
136 bool operator!=(const SendCodecSpec& rhs) const {
137 return !(*this == rhs);
138 }
139
140 bool nack_enabled = false;
141 bool transport_cc_enabled = false;
142 bool enable_codec_fec = false;
143 bool enable_opus_dtx = false;
144 int opus_max_playback_rate = 0;
145 int red_payload_type = -1;
146 int cng_payload_type = -1;
147 int cng_plfreq = -1;
148 webrtc::CodecInst codec_inst;
149 } send_codec_spec;
97 }; 150 };
98 151
99 // Starts stream activity. 152 // Starts stream activity.
100 // When a stream is active, it can receive, process and deliver packets. 153 // When a stream is active, it can receive, process and deliver packets.
101 virtual void Start() = 0; 154 virtual void Start() = 0;
102 // Stops stream activity. 155 // Stops stream activity.
103 // When a stream is stopped, it can't receive, process or deliver packets. 156 // When a stream is stopped, it can't receive, process or deliver packets.
104 virtual void Stop() = 0; 157 virtual void Stop() = 0;
105 158
106 // TODO(solenberg): Make payload_type a config property instead. 159 // TODO(solenberg): Make payload_type a config property instead.
107 virtual bool SendTelephoneEvent(int payload_type, int event, 160 virtual bool SendTelephoneEvent(int payload_type, int event,
108 int duration_ms) = 0; 161 int duration_ms) = 0;
109 162
110 virtual void SetMuted(bool muted) = 0; 163 virtual void SetMuted(bool muted) = 0;
111 164
112 virtual Stats GetStats() const = 0; 165 virtual Stats GetStats() const = 0;
113 166
114 protected: 167 protected:
115 virtual ~AudioSendStream() {} 168 virtual ~AudioSendStream() {}
116 }; 169 };
117 } // namespace webrtc 170 } // namespace webrtc
118 171
119 #endif // WEBRTC_API_CALL_AUDIO_SEND_STREAM_H_ 172 #endif // WEBRTC_API_CALL_AUDIO_SEND_STREAM_H_
OLDNEW
« no previous file with comments | « no previous file | webrtc/audio/audio_send_stream.h » ('j') | webrtc/audio/audio_send_stream.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698