Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2405173006:
Remove deprected functions from EncodedImageCallback and RtpRtcp (Closed)
|
Created:
4 years, 2 months ago by Sergey Ulanov Modified:
4 years, 1 month ago CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, video-team_agora.io, danilchap, yujie_mao (webrtc), zhuangzesen_agora.io, zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, perkj_webrtc, mflodman Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionRemove deprected functions from EncodedImageCallback and RtpRtcp
Removed EncodedImageCallback::Encoded() and RtpRtcp::SendOutgoingData().
These methods should no longer be used anywhere and it's safe to remove
them.
BUG=chromium:621691
Committed: https://crrev.com/c681250aaa2025836db7669694e323898e5c2ca7
Committed: https://crrev.com/2cb155aa8a6c3d432dee7384fcbc01ec742b00a7
Cr-Original-Commit-Position: refs/heads/master@{#14923}
Cr-Commit-Position: refs/heads/master@{#14935}
Patch Set 1 #Patch Set 2 : h264 #Patch Set 3 : android,ios #
Total comments: 2
Patch Set 4 : fix android #Messages
Total messages: 67 (45 generated)
sergeyu@chromium.org changed reviewers: + mflodman@webrtc.org, stefan@webrtc.org
The CQ bit was checked by sergeyu@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios_arm64_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_dbg/builds/13816) ios_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios_dbg/builds/19051) mac_compile_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/mac_compile_dbg/builds/...) win_drmemory_light on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_drmemory_light/buil...) win_x64_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_dbg/builds/2099)
The CQ bit was checked by sergeyu@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios_dbg/builds/19270)
The CQ bit was checked by sergeyu@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios64_sim_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_dbg/builds/11821) ios_arm64_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_dbg/builds/14150) ios_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios_dbg/builds/19389) presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/9490)
The CQ bit was checked by sergeyu@chromium.org to run a CQ dry run
Patchset #3 (id:40001) has been deleted
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Patchset #3 (id:40001) has been deleted
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/9491)
ping
It doesn't build on Android. https://codereview.webrtc.org/2405173006/diff/60001/webrtc/video_encoder.h File webrtc/video_encoder.h (left): https://codereview.webrtc.org/2405173006/diff/60001/webrtc/video_encoder.h#ol... webrtc/video_encoder.h:67: virtual int32_t Encoded(const EncodedImage& encoded_image, Is I assume this is safe to remove now and that no implementations uses it?
The CQ bit was checked by sergeyu@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/9690)
Patchset #4 (id:80001) has been deleted
The CQ bit was checked by sergeyu@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/9692)
Fixed android now. https://codereview.webrtc.org/2405173006/diff/60001/webrtc/video_encoder.h File webrtc/video_encoder.h (left): https://codereview.webrtc.org/2405173006/diff/60001/webrtc/video_encoder.h#ol... webrtc/video_encoder.h:67: virtual int32_t Encoded(const EncodedImage& encoded_image, On 2016/10/31 15:10:35, stefan-webrtc (holmer) wrote: > Is I assume this is safe to remove now and that no implementations uses it? Yes, I believe it's not being used anywhere anymore.
lgtm
The CQ bit was checked by sergeyu@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/9767)
Description was changed from ========== Remove deprected functions from EncodedImageCallback and RtpRtcp Removed EncodedImageCallback::Encoded() and RtpRtcp::SendOutgoingData(). These methods should no longer be used anywhere and it's safe to remove them. ========== to ========== Remove deprected functions from EncodedImageCallback and RtpRtcp Removed EncodedImageCallback::Encoded() and RtpRtcp::SendOutgoingData(). These methods should no longer be used anywhere and it's safe to remove them. BUG=chromium:621691 ==========
The CQ bit was checked by sergeyu@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Message was sent while issue was closed.
Description was changed from ========== Remove deprected functions from EncodedImageCallback and RtpRtcp Removed EncodedImageCallback::Encoded() and RtpRtcp::SendOutgoingData(). These methods should no longer be used anywhere and it's safe to remove them. BUG=chromium:621691 ========== to ========== Remove deprected functions from EncodedImageCallback and RtpRtcp Removed EncodedImageCallback::Encoded() and RtpRtcp::SendOutgoingData(). These methods should no longer be used anywhere and it's safe to remove them. BUG=chromium:621691 ==========
Message was sent while issue was closed.
Committed patchset #4 (id:100001)
Message was sent while issue was closed.
Description was changed from ========== Remove deprected functions from EncodedImageCallback and RtpRtcp Removed EncodedImageCallback::Encoded() and RtpRtcp::SendOutgoingData(). These methods should no longer be used anywhere and it's safe to remove them. BUG=chromium:621691 ========== to ========== Remove deprected functions from EncodedImageCallback and RtpRtcp Removed EncodedImageCallback::Encoded() and RtpRtcp::SendOutgoingData(). These methods should no longer be used anywhere and it's safe to remove them. BUG=chromium:621691 Committed: https://crrev.com/fa565842718ad178a7562721b25d916fbabc2b92 Cr-Commit-Position: refs/heads/master@{#14902} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/fa565842718ad178a7562721b25d916fbabc2b92 Cr-Commit-Position: refs/heads/master@{#14902}
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:100001) has been created in https://codereview.webrtc.org/2474433008/ by ehmaldonado@webrtc.org. The reason for reverting is: This might be breaking projects downstream..
Message was sent while issue was closed.
Description was changed from ========== Remove deprected functions from EncodedImageCallback and RtpRtcp Removed EncodedImageCallback::Encoded() and RtpRtcp::SendOutgoingData(). These methods should no longer be used anywhere and it's safe to remove them. BUG=chromium:621691 Committed: https://crrev.com/fa565842718ad178a7562721b25d916fbabc2b92 Cr-Commit-Position: refs/heads/master@{#14902} ========== to ========== Remove deprected functions from EncodedImageCallback and RtpRtcp Removed EncodedImageCallback::Encoded() and RtpRtcp::SendOutgoingData(). These methods should no longer be used anywhere and it's safe to remove them. BUG=chromium:621691 Committed: https://crrev.com/fa565842718ad178a7562721b25d916fbabc2b92 Cr-Commit-Position: refs/heads/master@{#14902} ==========
Description was changed from ========== Remove deprected functions from EncodedImageCallback and RtpRtcp Removed EncodedImageCallback::Encoded() and RtpRtcp::SendOutgoingData(). These methods should no longer be used anywhere and it's safe to remove them. BUG=chromium:621691 Committed: https://crrev.com/fa565842718ad178a7562721b25d916fbabc2b92 Cr-Commit-Position: refs/heads/master@{#14902} ========== to ========== Remove deprected functions from EncodedImageCallback and RtpRtcp Removed EncodedImageCallback::Encoded() and RtpRtcp::SendOutgoingData(). These methods should no longer be used anywhere and it's safe to remove them. BUG=chromium:621691 ==========
On 2016/11/03 14:00:04, ehmaldonado_webrtc wrote: > A revert of this CL (patchset #4 id:100001) has been created in > https://codereview.webrtc.org/2474433008/ by mailto:ehmaldonado@webrtc.org. > > The reason for reverting is: This might be breaking projects downstream.. I don't see any bots that where broken with this change. Relanding.
The CQ bit was checked by sergeyu@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Message was sent while issue was closed.
Description was changed from ========== Remove deprected functions from EncodedImageCallback and RtpRtcp Removed EncodedImageCallback::Encoded() and RtpRtcp::SendOutgoingData(). These methods should no longer be used anywhere and it's safe to remove them. BUG=chromium:621691 ========== to ========== Remove deprected functions from EncodedImageCallback and RtpRtcp Removed EncodedImageCallback::Encoded() and RtpRtcp::SendOutgoingData(). These methods should no longer be used anywhere and it's safe to remove them. BUG=chromium:621691 ==========
Message was sent while issue was closed.
Committed patchset #4 (id:100001)
Message was sent while issue was closed.
Description was changed from ========== Remove deprected functions from EncodedImageCallback and RtpRtcp Removed EncodedImageCallback::Encoded() and RtpRtcp::SendOutgoingData(). These methods should no longer be used anywhere and it's safe to remove them. BUG=chromium:621691 ========== to ========== Remove deprected functions from EncodedImageCallback and RtpRtcp Removed EncodedImageCallback::Encoded() and RtpRtcp::SendOutgoingData(). These methods should no longer be used anywhere and it's safe to remove them. BUG=chromium:621691 Committed: https://crrev.com/c681250aaa2025836db7669694e323898e5c2ca7 Cr-Commit-Position: refs/heads/master@{#14923} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/c681250aaa2025836db7669694e323898e5c2ca7 Cr-Commit-Position: refs/heads/master@{#14923}
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:100001) has been created in https://codereview.webrtc.org/2479643002/ by kjellander@webrtc.org. The reason for reverting is: Still breaks internal downstream project. Sergey: Please update internal project before relanding this..
Message was sent while issue was closed.
Description was changed from ========== Remove deprected functions from EncodedImageCallback and RtpRtcp Removed EncodedImageCallback::Encoded() and RtpRtcp::SendOutgoingData(). These methods should no longer be used anywhere and it's safe to remove them. BUG=chromium:621691 Committed: https://crrev.com/c681250aaa2025836db7669694e323898e5c2ca7 Cr-Commit-Position: refs/heads/master@{#14923} ========== to ========== Remove deprected functions from EncodedImageCallback and RtpRtcp Removed EncodedImageCallback::Encoded() and RtpRtcp::SendOutgoingData(). These methods should no longer be used anywhere and it's safe to remove them. BUG=chromium:621691 Committed: https://crrev.com/c681250aaa2025836db7669694e323898e5c2ca7 Cr-Commit-Position: refs/heads/master@{#14923} ==========
Updated dependent code to use the new function. Relanding.
The CQ bit was checked by sergeyu@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_x64_clang_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_clang_dbg/build...)
The CQ bit was checked by sergeyu@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Message was sent while issue was closed.
Description was changed from ========== Remove deprected functions from EncodedImageCallback and RtpRtcp Removed EncodedImageCallback::Encoded() and RtpRtcp::SendOutgoingData(). These methods should no longer be used anywhere and it's safe to remove them. BUG=chromium:621691 Committed: https://crrev.com/c681250aaa2025836db7669694e323898e5c2ca7 Cr-Commit-Position: refs/heads/master@{#14923} ========== to ========== Remove deprected functions from EncodedImageCallback and RtpRtcp Removed EncodedImageCallback::Encoded() and RtpRtcp::SendOutgoingData(). These methods should no longer be used anywhere and it's safe to remove them. BUG=chromium:621691 Committed: https://crrev.com/c681250aaa2025836db7669694e323898e5c2ca7 Cr-Commit-Position: refs/heads/master@{#14923} ==========
Message was sent while issue was closed.
Committed patchset #4 (id:100001)
Message was sent while issue was closed.
Description was changed from ========== Remove deprected functions from EncodedImageCallback and RtpRtcp Removed EncodedImageCallback::Encoded() and RtpRtcp::SendOutgoingData(). These methods should no longer be used anywhere and it's safe to remove them. BUG=chromium:621691 Committed: https://crrev.com/c681250aaa2025836db7669694e323898e5c2ca7 Cr-Commit-Position: refs/heads/master@{#14923} ========== to ========== Remove deprected functions from EncodedImageCallback and RtpRtcp Removed EncodedImageCallback::Encoded() and RtpRtcp::SendOutgoingData(). These methods should no longer be used anywhere and it's safe to remove them. BUG=chromium:621691 Committed: https://crrev.com/c681250aaa2025836db7669694e323898e5c2ca7 Committed: https://crrev.com/2cb155aa8a6c3d432dee7384fcbc01ec742b00a7 Cr-Original-Commit-Position: refs/heads/master@{#14923} Cr-Commit-Position: refs/heads/master@{#14935} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/2cb155aa8a6c3d432dee7384fcbc01ec742b00a7 Cr-Commit-Position: refs/heads/master@{#14935} |
