Use kCGDisplayStreamUpdateDirtyRects.

Use kCGDisplayStreamUpdateDirtyRects.

It combines the information from kCGDisplayStreamUpdateMovedRects and
kCGDisplayStreamUpdateRefreshedRects.

BUG=

[erikchen, 2016-10-10 21:54:41]

erikchen@chromium.org changed reviewers:
+ sergeyu@chromium.org

[erikchen, 2016-10-10 21:54:42]

sergeyu: Please review.

https://codereview.chromium.org/2404983002/diff/1/webrtc/modules/desktop_capt...
File webrtc/modules/desktop_capture/screen_capturer_mac.mm (right):

https://codereview.chromium.org/2404983002/diff/1/webrtc/modules/desktop_capt...
webrtc/modules/desktop_capture/screen_capturer_mac.mm:944: rects =
CGDisplayStreamUpdateGetRects(
It's not clear to me whether CGDisplayStreamUpdateGetRects is still necessary,
and how it functions on refresh rects. Do we have a way of testing this?

[Sergey Ulanov, 2016-10-11 17:32:10]

lgtm when my comment is addressed

https://codereview.chromium.org/2404983002/diff/20001/webrtc/modules/desktop_...
File webrtc/modules/desktop_capture/screen_capturer_mac.mm (right):

https://codereview.chromium.org/2404983002/diff/20001/webrtc/modules/desktop_...
webrtc/modules/desktop_capture/screen_capturer_mac.mm:997: ScreenRefresh(count,
rect_array);
ScreenRefresh() is called only here, so I don't think you need it separate from
ScreenRefreshCallback(). Move ScreenConfigurationChanged() call to
ScreenRefresh() and remove ScreenRefreshCallback().

[erikchen, 2016-10-11 17:41:35]

On 2016/10/11 17:32:10, Sergey Ulanov wrote:
> lgtm when my comment is addressed
> 
>
https://codereview.chromium.org/2404983002/diff/20001/webrtc/modules/desktop_...
> File webrtc/modules/desktop_capture/screen_capturer_mac.mm (right):
> 
>
https://codereview.chromium.org/2404983002/diff/20001/webrtc/modules/desktop_...
> webrtc/modules/desktop_capture/screen_capturer_mac.mm:997:
ScreenRefresh(count,
> rect_array);
> ScreenRefresh() is called only here, so I don't think you need it separate
from
> ScreenRefreshCallback(). Move ScreenConfigurationChanged() call to
> ScreenRefresh() and remove ScreenRefreshCallback().

sergeyu: Can you respond to my question? Copied here for your convenience:
"""
It's not clear to me whether CGDisplayStreamUpdateGetRects is still necessary,
and how it functions on refresh rects. Do we have a way of testing this?
"""

[Sergey Ulanov, 2016-10-11 17:59:22]

Sorry I missed your question

https://codereview.chromium.org/2404983002/diff/1/webrtc/modules/desktop_capt...
File webrtc/modules/desktop_capture/screen_capturer_mac.mm (right):

https://codereview.chromium.org/2404983002/diff/1/webrtc/modules/desktop_capt...
webrtc/modules/desktop_capture/screen_capturer_mac.mm:944: rects =
CGDisplayStreamUpdateGetRects(
On 2016/10/10 21:54:42, erikchen wrote:
> It's not clear to me whether CGDisplayStreamUpdateGetRects is still necessary,
> and how it functions on refresh rects. Do we have a way of testing this?

Dirty rects are passed to helper_ and then Capture() gets dirty region from
helper_ and captures it for the new frame. Test coverage is lacking there :-(.
There are some unittests in screen_capturer_mac_unittest.cc, but they perform
only very minimal checks. There are also tests in screen_capturer_unittest.cc,
but they are disabled on Mac because there is currently no ScreenDrawer
implementation for Mac.

To test this change you can build chrome with this CL and then load this app:
//chrome/common/extensions/docs/examples/api/desktopCapture
It should show correct screen updates when something changes on the screen.

[erikchen, 2016-10-12 18:53:54]

Description was changed from

==========
Use kCGDisplayStreamUpdateDirtyRects.

It combines the information from kCGDisplayStreamUpdateMovedRects and
kCGDisplayStreamUpdateRefreshedRects.

BUG=
==========

to

==========
Use kCGDisplayStreamUpdateDirtyRects.

It combines the information from kCGDisplayStreamUpdateMovedRects and
kCGDisplayStreamUpdateRefreshedRects.

BUG=
==========