Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(938)

Issue 2404253004: Rename variables to reflect that DelayBasedBwe lives on the send side rather than receive side. (Closed)

Created:
4 years, 2 months ago by terelius
Modified:
4 years, 2 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Rename variables to reflect that DelayBasedBwe lives on the send side rather than receive side. BUG=0 Committed: https://crrev.com/6ed592d0aba9a13715034b5f7c245b4e95ba069d Cr-Commit-Position: refs/heads/master@{#14662}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -17 lines) Patch
M webrtc/modules/congestion_controller/delay_based_bwe.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/congestion_controller/delay_based_bwe.cc View 5 chunks +15 lines, -15 lines 2 comments Download

Messages

Total messages: 13 (7 generated)
terelius
4 years, 2 months ago (2016-10-12 20:15:25 UTC) #2
stefan-webrtc
lgtm https://codereview.webrtc.org/2404253004/diff/1/webrtc/modules/congestion_controller/delay_based_bwe.cc File webrtc/modules/congestion_controller/delay_based_bwe.cc (right): https://codereview.webrtc.org/2404253004/diff/1/webrtc/modules/congestion_controller/delay_based_bwe.cc#newcode133 webrtc/modules/congestion_controller/delay_based_bwe.cc:133: receiver_incoming_bitrate_.Rate(info.arrival_time_ms); This seems to be unused. Feel free ...
4 years, 2 months ago (2016-10-15 05:21:38 UTC) #3
terelius
https://codereview.webrtc.org/2404253004/diff/1/webrtc/modules/congestion_controller/delay_based_bwe.cc File webrtc/modules/congestion_controller/delay_based_bwe.cc (right): https://codereview.webrtc.org/2404253004/diff/1/webrtc/modules/congestion_controller/delay_based_bwe.cc#newcode133 webrtc/modules/congestion_controller/delay_based_bwe.cc:133: receiver_incoming_bitrate_.Rate(info.arrival_time_ms); On 2016/10/15 05:21:37, stefan-webrtc (holmer) wrote: > This ...
4 years, 2 months ago (2016-10-18 12:39:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2404253004/1
4 years, 2 months ago (2016-10-18 12:40:23 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-18 12:55:36 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-18 12:55:40 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6ed592d0aba9a13715034b5f7c245b4e95ba069d
Cr-Commit-Position: refs/heads/master@{#14662}

Powered by Google App Engine
This is Rietveld 408576698