Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2404233004:
Call OnTransportFeedback just when feedback_observer exist. (Closed)
|
Created:
4 years, 2 months ago by michaelt Modified:
4 years, 2 months ago CC:
webrtc-reviews_webrtc.org, henrika_webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc, the sun Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionCall OnTransportFeedback just when feedback_observer exist.
BUG=webrtc:6523
Committed: https://crrev.com/9960bb14695f5c9a1c60c0f371a21d58b663e8ff
Cr-Commit-Position: refs/heads/master@{#14667}
Patch Set 1 #
Messages
Total messages: 24 (13 generated)
Description was changed from ========== Call OnTransportFeedback just when feedback_observer exist. BUG= ========== to ========== Call OnTransportFeedback just when feedback_observer exist. BUG=webrtc:6523 ==========
michaelt@webrtc.org changed reviewers: + minyue@webrtc.org, solenberg@webrtc.org, stefan@webrtc.org
The CQ bit was checked by michaelt@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
oops! lgtm
lgtm
The CQ bit was checked by stefan@webrtc.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/9232)
The CQ bit was checked by michaelt@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/9242)
The CQ bit was checked by michaelt@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Message was sent while issue was closed.
Description was changed from ========== Call OnTransportFeedback just when feedback_observer exist. BUG=webrtc:6523 ========== to ========== Call OnTransportFeedback just when feedback_observer exist. BUG=webrtc:6523 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Call OnTransportFeedback just when feedback_observer exist. BUG=webrtc:6523 ========== to ========== Call OnTransportFeedback just when feedback_observer exist. BUG=webrtc:6523 Committed: https://crrev.com/9960bb14695f5c9a1c60c0f371a21d58b663e8ff Cr-Commit-Position: refs/heads/master@{#14667} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/9960bb14695f5c9a1c60c0f371a21d58b663e8ff Cr-Commit-Position: refs/heads/master@{#14667} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
