webrtc/modules/audio_coding/neteq/dtmf_buffer_unittest.cc - Issue 2404183003: Fix bug in DTMF generation where events with level > 36 would be ignored.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/neteq/dtmf_buffer_unittest.cc

Issue 2404183003: Fix bug in DTMF generation where events with level > 36 would be ignored. (Closed)

Patch Set: reviewer comments Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/audio_coding/neteq/dtmf_buffer_unittest.cc

diff --git a/webrtc/modules/audio_coding/neteq/dtmf_buffer_unittest.cc b/webrtc/modules/audio_coding/neteq/dtmf_buffer_unittest.cc

index 1252f819d1f2062e68c020719e94f7cf5819f21f..d906d1ca5292d8ce96f4c2a3a099d253a4a9c3ef 100644

--- a/webrtc/modules/audio_coding/neteq/dtmf_buffer_unittest.cc

+++ b/webrtc/modules/audio_coding/neteq/dtmf_buffer_unittest.cc

@@ -282,7 +282,7 @@ TEST(DtmfBuffer, InvalidEvents) {

// Invalid volume.

event.volume = -1;

EXPECT_EQ(DtmfBuffer::kInvalidEventParameters, buffer.InsertEvent(event));

- event.volume = 37;

+ event.volume = 64;

EXPECT_EQ(DtmfBuffer::kInvalidEventParameters, buffer.InsertEvent(event));

event.volume = 0; // Valid value;