Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Unified Diff: webrtc/modules/audio_coding/neteq/dtmf_buffer.cc

Issue 2404183003: Fix bug in DTMF generation where events with level > 36 would be ignored. (Closed)
Patch Set: fix other tests Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/audio_coding/neteq/dtmf_buffer.cc
diff --git a/webrtc/modules/audio_coding/neteq/dtmf_buffer.cc b/webrtc/modules/audio_coding/neteq/dtmf_buffer.cc
index 779d1d340b46559169f4ab2140e6710ae36cddf2..3685fc1ef4a8b64d334384e8b7f633fa334f5a07 100644
--- a/webrtc/modules/audio_coding/neteq/dtmf_buffer.cc
+++ b/webrtc/modules/audio_coding/neteq/dtmf_buffer.cc
@@ -99,7 +99,7 @@ int DtmfBuffer::ParseEvent(uint32_t rtp_timestamp,
// existing one.
int DtmfBuffer::InsertEvent(const DtmfEvent& event) {
if (event.event_no < 0 || event.event_no > 15 ||
- event.volume < 0 || event.volume > 36 ||
+ event.volume < 0 || event.volume > 63 ||
hlundin-webrtc 2016/10/11 09:08:36 This is a bug that was introduced by yours truly i
the sun 2016/10/11 09:44:53 Acknowledged.
event.duration <= 0 || event.duration > 65535) {
LOG(LS_WARNING) << "InsertEvent invalid parameters";
return kInvalidEventParameters;

Powered by Google App Engine
This is Rietveld 408576698