Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(673)

Issue 2404173002: Add asyncstuntcpsocket_unittest.cc to rtc_unittests (Closed)

Created:
4 years, 2 months ago by kjellander_webrtc
Modified:
4 years, 2 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add asyncstuntcpsocket_unittest.cc to rtc_unittests asyncstuntcpsocket_unittest.cc never seem to have been added along with the other tests in webrtc/p2p. Luckily the tests pass. BUG=None NOTRY=True Committed: https://crrev.com/3283cf917bf2899a7d1e797593704d2068001e6a Cr-Commit-Position: refs/heads/master@{#14632}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M webrtc/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
kjellander_webrtc
4 years, 2 months ago (2016-10-13 05:27:47 UTC) #2
Taylor Brandstetter
lgtm
4 years, 2 months ago (2016-10-13 06:41:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2404173002/1
4 years, 2 months ago (2016-10-13 13:20:46 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-13 13:35:49 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-10-13 13:36:01 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3283cf917bf2899a7d1e797593704d2068001e6a
Cr-Commit-Position: refs/heads/master@{#14632}

Powered by Google App Engine
This is Rietveld 408576698