Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(530)

Unified Diff: webrtc/api/android/java/src/org/webrtc/Metrics.java

Issue 2403463002: Allow custom metrics implementations on Android. (Closed)
Patch Set: Changes according to kjellander's comments. #1 Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/api/android/java/src/org/webrtc/Metrics.java
diff --git a/webrtc/api/android/java/src/org/webrtc/Metrics.java b/webrtc/api/android/java/src/org/webrtc/Metrics.java
index 7f0f5cb979a3aab8b135f4764181194033559c2c..ca19489e892466148e8cee2b5aa4eee28cc1901d 100644
--- a/webrtc/api/android/java/src/org/webrtc/Metrics.java
+++ b/webrtc/api/android/java/src/org/webrtc/Metrics.java
@@ -59,36 +59,6 @@ public class Metrics {
}
}
- /**
- * Class for holding the native pointer of a histogram. Since there is no way to destroy a
- * histogram, please don't create unnecessary instances of this object. This class is thread safe.
- *
- * Usage example:
- * private static final Histogram someMetricHistogram =
- * Histogram.createCounts("WebRTC.Video.SomeMetric", 1, 10000, 50);
- * someMetricHistogram.addSample(someVariable);
- */
- static class Histogram {
- private final long handle;
- private final String name; // Only used for logging.
-
- private Histogram(long handle, String name) {
- this.handle = handle;
- this.name = name;
- }
-
- static public Histogram createCounts(String name, int min, int max, int bucketCount) {
- return new Histogram(nativeCreateCounts(name, min, max, bucketCount), name);
- }
-
- public void addSample(int sample) {
- nativeAddSample(handle, sample);
- }
-
- private static native long nativeCreateCounts(String name, int min, int max, int bucketCount);
- private static native void nativeAddSample(long handle, int sample);
- }
-
private void add(String name, HistogramInfo info) {
map.put(name, info);
}

Powered by Google App Engine
This is Rietveld 408576698