Allow custom metrics implementations on Android.

Allow custom metrics implementations on Android.

BUG=webrtc:6499
Committed: https://crrev.com/de609b26c5fc77fd3388eae5594ee8a634edf8da
Cr-Commit-Position: refs/heads/master@{#15169}

[sakal, 2016-10-10 05:39:12]

Patchset #1 (id:1) has been deleted

[sakal, 2016-10-10 05:39:22]

Patchset #1 (id:20001) has been deleted

[sakal, 2016-10-10 05:40:41]

Description was changed from

==========
Allow custom metrics implementations on Android.

BUG=
==========

to

==========
Allow custom metrics implementations on Android.

BUG=webrtc:6499
==========

[sakal, 2016-10-10 05:40:41]

sakal@webrtc.org changed reviewers:
+ kjellander@webrtc.org

[sakal, 2016-10-10 05:41:07]

sakal@webrtc.org changed reviewers:
+ magjed@webrtc.org

[sakal, 2016-10-10 05:41:16]

PTAL

[kjellander_webrtc, 2016-10-12 01:03:49]

https://codereview.webrtc.org/2403463002/diff/40001/webrtc/api/api.gyp
File webrtc/api/api.gyp (right):

https://codereview.webrtc.org/2403463002/diff/40001/webrtc/api/api.gyp#newcode33
webrtc/api/api.gyp:33:
'<(webrtc_root)/system_wrappers/system_wrappers.gyp:field_trial_default',
Please update the dependencies here as well, as GYP is still used in the
internal project.

[magjed_webrtc, 2016-10-13 22:56:55]

lgtm

[sakal, 2016-10-17 07:28:32]

https://codereview.webrtc.org/2403463002/diff/40001/webrtc/api/api.gyp
File webrtc/api/api.gyp (right):

https://codereview.webrtc.org/2403463002/diff/40001/webrtc/api/api.gyp#newcode33
webrtc/api/api.gyp:33:
'<(webrtc_root)/system_wrappers/system_wrappers.gyp:field_trial_default',
On 2016/10/12 01:03:48, kjellander_webrtc wrote:
> Please update the dependencies here as well, as GYP is still used in the
> internal project.

Done.

[kjellander_webrtc, 2016-10-17 07:34:00]

https://codereview.webrtc.org/2403463002/diff/60001/webrtc/api/api.gyp
File webrtc/api/api.gyp (right):

https://codereview.webrtc.org/2403463002/diff/60001/webrtc/api/api.gyp#newcode33
webrtc/api/api.gyp:33:
'<(webrtc_root)/system_wrappers/system_wrappers.gyp:field_trial_default',
This should be removed too.

https://codereview.webrtc.org/2403463002/diff/60001/webrtc/api/api.gyp#newcode80
webrtc/api/api.gyp:80:
'<(webrtc_root)/system_wrappers/system_wrappers.gyp:metrics_default',
Add field_trial_default too.

[sakal, 2016-10-17 07:39:43]

https://codereview.webrtc.org/2403463002/diff/60001/webrtc/api/api.gyp
File webrtc/api/api.gyp (right):

https://codereview.webrtc.org/2403463002/diff/60001/webrtc/api/api.gyp#newcode33
webrtc/api/api.gyp:33:
'<(webrtc_root)/system_wrappers/system_wrappers.gyp:field_trial_default',
On 2016/10/17 07:34:00, kjellander_webrtc wrote:
> This should be removed too.

Done.

https://codereview.webrtc.org/2403463002/diff/60001/webrtc/api/api.gyp#newcode80
webrtc/api/api.gyp:80:
'<(webrtc_root)/system_wrappers/system_wrappers.gyp:metrics_default',
On 2016/10/17 07:34:00, kjellander_webrtc wrote:
> Add field_trial_default too.

Done.

[kjellander_webrtc, 2016-10-17 07:50:06]

lgtm

[sakal, 2016-10-17 08:00:11]

The CQ bit was checked by sakal@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-17 08:00:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-17 08:03:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-17 08:03:58]

Dry run: Try jobs failed on following builders:
  android_arm64_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/build...)
  android_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/17620)

[sakal, 2016-10-17 09:49:07]

The CQ bit was checked by sakal@webrtc.org

[sakal, 2016-10-17 09:49:08]

The patchset sent to the CQ was uploaded after l-g-t-m from magjed@webrtc.org,
kjellander@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2403463002/#ps100001 (title:
"Remove unused constructor parameter from Histogram.")

[commit-bot: I haz the power, 2016-10-17 09:49:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[sakal, 2016-10-17 09:49:40]

The CQ bit was unchecked by sakal@webrtc.org

[sakal, 2016-10-17 12:30:21]

The CQ bit was checked by sakal@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-17 12:30:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-17 12:39:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-17 12:39:43]

Dry run: Try jobs failed on following builders:
  android_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_rel/builds/17463)

[sakal, 2016-11-18 09:27:26]

Patchset #6 (id:140001) has been deleted

[sakal, 2016-11-18 10:31:32]

The CQ bit was checked by sakal@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-18 10:31:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-18 10:45:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-18 10:45:37]

Dry run: Try jobs failed on following builders:
  android_clang_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_clang_dbg/build...)

[sakal, 2016-11-18 11:01:50]

The CQ bit was checked by sakal@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-18 11:01:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-18 11:06:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-18 11:06:13]

Dry run: Try jobs failed on following builders:
  android_clang_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_clang_dbg/build...)

[sakal, 2016-11-18 12:40:26]

The CQ bit was checked by sakal@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-18 12:40:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-18 12:58:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-18 12:58:58]

Dry run: This issue passed the CQ dry run.

[sakal, 2016-11-21 09:10:57]

The CQ bit was checked by sakal@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-21 09:11:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[sakal, 2016-11-21 09:24:57]

I fixed the problems with the build, PTAL.

[commit-bot: I haz the power, 2016-11-21 09:30:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-21 09:30:20]

Dry run: This issue passed the CQ dry run.

[kjellander_webrtc, 2016-11-21 09:48:43]

On 2016/11/21 09:24:57, sakal wrote:
> I fixed the problems with the build, PTAL.

lgtm. woho!

[magjed_webrtc, 2016-11-21 11:39:16]

lgtm

[sakal, 2016-11-21 11:40:16]

The CQ bit was checked by sakal@webrtc.org

[commit-bot: I haz the power, 2016-11-21 11:40:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-21 11:44:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-21 11:44:53]

Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/10442)

[sakal, 2016-11-21 15:18:24]

The CQ bit was checked by sakal@webrtc.org

[sakal, 2016-11-21 15:18:24]

The patchset sent to the CQ was uploaded after l-g-t-m from magjed@webrtc.org,
kjellander@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2403463002/#ps260001 (title:
"Rebase.")

[commit-bot: I haz the power, 2016-11-21 15:18:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-21 15:41:03]

CQ is committing da patch.

Bot data: {"patchset_id": 260001, "attempt_start_ts": 1479741504187110,
"parent_rev": "5e279bd30c5ceccc012735a21ac70d370888306d", "commit_rev":
"ce9c010909d951ca1ebdcc5622ef4fb9082a0ed7"}

[commit-bot: I haz the power, 2016-11-21 15:41:07]

Description was changed from

==========
Allow custom metrics implementations on Android.

BUG=webrtc:6499
==========

to

==========
Allow custom metrics implementations on Android.

BUG=webrtc:6499
==========

[commit-bot: I haz the power, 2016-11-21 15:41:08]

Committed patchset #11 (id:260001)

[commit-bot: I haz the power, 2016-11-21 15:41:13]

Description was changed from

==========
Allow custom metrics implementations on Android.

BUG=webrtc:6499
==========

to

==========
Allow custom metrics implementations on Android.

BUG=webrtc:6499

Committed: https://crrev.com/de609b26c5fc77fd3388eae5594ee8a634edf8da
Cr-Commit-Position: refs/heads/master@{#15169}
==========

[commit-bot: I haz the power, 2016-11-21 15:41:15]

Patchset 11 (id:??) landed as
https://crrev.com/de609b26c5fc77fd3388eae5594ee8a634edf8da
Cr-Commit-Position: refs/heads/master@{#15169}

[philipel, 2016-11-21 16:29:42]

A revert of this CL (patchset #11 id:260001) has been created in
https://codereview.webrtc.org/2516403002/ by philipel@webrtc.org.

The reason for reverting is: Break downstream tests..