Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2402613002:
Add support for component builds on Windows Swarming. Attempt 2 (Closed)
|
Created:
4 years, 2 months ago by ehmaldonado_webrtc Modified:
4 years, 2 months ago CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionAdd support for component builds on Windows Swarming. Attempt 2
Some run time dependencies on MSVC were missing and had to be added to rtc_base_approved.
TBR=kjellander@webrtc.org
BUG=chromium:497757
NOTRY=True
Committed: https://crrev.com/2334b708518ebbbcd8f50c30b1333f4f53231c3c
Cr-Commit-Position: refs/heads/master@{#14566}
Patch Set 1 : Pristine copy of 2389133002 #Patch Set 2 : Add && is_win #
Total comments: 1
Messages
Total messages: 14 (7 generated)
Patchset #1 (id:1) has been deleted
Description was changed from ========== Add support for component builds on Windows Swarming. Attempt 2 Some run time dependencies on MSVC were missing and had to be added to rtc_base_approved. R=kjellander@webrtc.org BUG=chromium:497757 ========== to ========== Add support for component builds on Windows Swarming. Attempt 2 Some run time dependencies on MSVC were missing and had to be added to rtc_base_approved. TBR=kjellander@webrtc.org BUG=chromium:497757 ==========
Description was changed from ========== Add support for component builds on Windows Swarming. Attempt 2 Some run time dependencies on MSVC were missing and had to be added to rtc_base_approved. TBR=kjellander@webrtc.org BUG=chromium:497757 ========== to ========== Add support for component builds on Windows Swarming. Attempt 2 Some run time dependencies on MSVC were missing and had to be added to rtc_base_approved. TBR=kjellander@webrtc.org BUG=chromium:497757 NOTRY=True ==========
The CQ bit was checked by ehmaldonado@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Message was sent while issue was closed.
Description was changed from ========== Add support for component builds on Windows Swarming. Attempt 2 Some run time dependencies on MSVC were missing and had to be added to rtc_base_approved. TBR=kjellander@webrtc.org BUG=chromium:497757 NOTRY=True ========== to ========== Add support for component builds on Windows Swarming. Attempt 2 Some run time dependencies on MSVC were missing and had to be added to rtc_base_approved. TBR=kjellander@webrtc.org BUG=chromium:497757 NOTRY=True ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Add support for component builds on Windows Swarming. Attempt 2 Some run time dependencies on MSVC were missing and had to be added to rtc_base_approved. TBR=kjellander@webrtc.org BUG=chromium:497757 NOTRY=True ========== to ========== Add support for component builds on Windows Swarming. Attempt 2 Some run time dependencies on MSVC were missing and had to be added to rtc_base_approved. TBR=kjellander@webrtc.org BUG=chromium:497757 NOTRY=True Committed: https://crrev.com/2334b708518ebbbcd8f50c30b1333f4f53231c3c Cr-Commit-Position: refs/heads/master@{#14566} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/2334b708518ebbbcd8f50c30b1333f4f53231c3c Cr-Commit-Position: refs/heads/master@{#14566}
Message was sent while issue was closed.
lgtm
Message was sent while issue was closed.
thakis@chromium.org changed reviewers: + thakis@chromium.org
Message was sent while issue was closed.
https://codereview.webrtc.org/2402613002/diff/40001/webrtc/base/BUILD.gn File webrtc/base/BUILD.gn (right): https://codereview.webrtc.org/2402613002/diff/40001/webrtc/base/BUILD.gn#newc... webrtc/base/BUILD.gn:274: data += [ "$clang_base_path/lib/clang/$clang_version/lib/windows/clang_rt.asan_dynamic-x86_64.dll" ] you need to import build/config/clang/clang.gni at the top. Currently, https://build.chromium.org/p/chromium.fyi/builders/CrWinAsan%28dll%29/builds/... is broken because of this change: Writing """\ clang_use_chrome_plugins = false is_asan = true is_clang = true is_component_build = true is_debug = false llvm_force_head_revision = true symbol_level = 2 target_cpu = "x86" v8_enable_verify_heap = true """ to C:\b\c\b\CrWinAsan_dll_\src\out\Release\args.gn. C:\b\c\b\CrWinAsan_dll_\src\buildtools\win\gn.exe gen //out/Release --check --runtime-deps-list-file=C:\b\c\b\CrWinAsan_dll_\src\out\Release\runtime_deps -> returned 1 ERROR at //third_party/webrtc/base/BUILD.gn:276:21: Undefined identifier in string expansion. data += [ "$clang_base_path/lib/clang/$clang_version/lib/windows/clang_rt.asan_dynamic-i386.dll" ] ^-------------- "clang_base_path" is not currently in scope. See //content/test/BUILD.gn:307:7: which caused the file to be included. "//third_party/webrtc/base:rtc_base", ^----------------- Please fix quickly.
Message was sent while issue was closed.
On 2016/10/17 15:32:25, Nico (mostly afk until Oct 23) wrote: > https://codereview.webrtc.org/2402613002/diff/40001/webrtc/base/BUILD.gn > File webrtc/base/BUILD.gn (right): > > https://codereview.webrtc.org/2402613002/diff/40001/webrtc/base/BUILD.gn#newc... > webrtc/base/BUILD.gn:274: data += [ > "$clang_base_path/lib/clang/$clang_version/lib/windows/clang_rt.asan_dynamic-x86_64.dll" > ] > you need to import build/config/clang/clang.gni at the top. Currently, > https://build.chromium.org/p/chromium.fyi/builders/CrWinAsan%28dll%29/builds/... > is broken because of this change: > > > Writing """\ > clang_use_chrome_plugins = false > is_asan = true > is_clang = true > is_component_build = true > is_debug = false > llvm_force_head_revision = true > symbol_level = 2 > target_cpu = "x86" > v8_enable_verify_heap = true > """ to C:\b\c\b\CrWinAsan_dll_\src\out\Release\args.gn. > > C:\b\c\b\CrWinAsan_dll_\src\buildtools\win\gn.exe gen //out/Release --check > --runtime-deps-list-file=C:\b\c\b\CrWinAsan_dll_\src\out\Release\runtime_deps > -> returned 1 > ERROR at //third_party/webrtc/base/BUILD.gn:276:21: Undefined identifier in > string expansion. > data += [ > "$clang_base_path/lib/clang/$clang_version/lib/windows/clang_rt.asan_dynamic-i386.dll" > ] > ^-------------- > "clang_base_path" is not currently in scope. > See //content/test/BUILD.gn:307:7: which caused the file to be included. > "//third_party/webrtc/base:rtc_base", > ^----------------- > > > Please fix quickly. This was fixed in https://codereview.webrtc.org/2422223002/ which was quickly imported and seems to have solved the problem. |
