Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 2401673002: Delete old video defines in engine config and rename file (Closed)

Created:
4 years, 2 months ago by mflodman
Modified:
4 years, 2 months ago
Reviewers:
the sun
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, video-team_agora.io, yujie_mao (webrtc), kwiberg-webrtc, stefan-webrtc, Andrew MacDonald, zhengzhonghou_agora.io, henrika_webrtc, hlundin-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, qiang.lu, niklas.enbom, peah-webrtc, minyue-webrtc, the sun, perkj_webrtc, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Delete old video defines in engine config. This CL deletes the old and not used video defines in engine_configurations.h and pre-pends voice_ to indicate there are only voice/audio defines left in the file. BUG=none R=solenberg@webrtc.org Committed: https://crrev.com/7056be937f040e8d794b6f733e1eb409a62dceef Cr-Commit-Position: refs/heads/master@{#14558}

Patch Set 1 #

Patch Set 2 : And GYP #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -141 lines) Patch
M webrtc/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/DEPS View 2 chunks +1 line, -1 line 0 comments Download
M webrtc/common.gyp View 1 1 chunk +1 line, -1 line 0 comments Download
D webrtc/engine_configurations.h View 1 chunk +0 lines, -74 lines 0 comments Download
M webrtc/modules/audio_coding/acm2/acm_codec_database.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/acm2/acm_common_defs.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/acm2/acm_receiver.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/acm2/codec_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/audio_decoder_impl.h View 2 chunks +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/test/APITest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/test/RTPFile.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/test/TestAllCodecs.cc View 2 chunks +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/test/TestRedFec.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/test/TestStereo.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/test/TestVADDTX.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/test/TwoWayCommunication.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/test/delay_test.cc View 2 chunks +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/test/opus_test.cc View 2 chunks +1 line, -1 line 0 comments Download
M webrtc/modules/audio_conference_mixer/source/audio_conference_mixer_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_mixer/audio_mixer_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/media_file/media_file_defines.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/media_file/media_file_utility.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/utility/include/file_player.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/utility/include/file_recorder.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/utility/source/file_player.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/utility/source/file_recorder.cc View 2 chunks +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/codec_database.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/generic_encoder.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/video/rtp_stream_receiver.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/voice_engine/test/auto_test/fixtures/before_initialization_fixture.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/voice_engine/test/auto_test/voe_standard_test.cc View 2 chunks +1 line, -1 line 0 comments Download
M webrtc/voice_engine/test/auto_test/voe_test_common.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/voice_engine/test/auto_test/voe_test_defines.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/voice_engine/test/cmd_test/voe_cmd_test.cc View 2 chunks +1 line, -1 line 0 comments Download
M webrtc/voice_engine/voice_engine_defines.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/voice_engine/voice_engine_impl.h View 1 chunk +1 line, -1 line 0 comments Download
A + webrtc/voice_engine_configurations.h View 2 chunks +3 lines, -31 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
mflodman
Fredrik, This CL removes a few defines that are not used for video anymore. So ...
4 years, 2 months ago (2016-10-06 15:26:18 UTC) #2
the sun
lgtm
4 years, 2 months ago (2016-10-06 17:09:31 UTC) #3
mflodman
Committed patchset #2 (id:20001) manually as 7056be937f040e8d794b6f733e1eb409a62dceef (presubmit successful).
4 years, 2 months ago (2016-10-07 05:07:45 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 05:07:46 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7056be937f040e8d794b6f733e1eb409a62dceef
Cr-Commit-Position: refs/heads/master@{#14558}

Powered by Google App Engine
This is Rietveld 408576698