Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2401613002:
Cleanup unused dependency on video_capture_module (Closed)
|
Created:
4 years, 2 months ago by perkj_webrtc Modified:
4 years, 2 months ago CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, perkj_webrtc, mflodman Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionCleanup unused dependency on video_capture_module.
BUG=none
TBR=mflodman@webrtc.org
Committed: https://crrev.com/ae04e36f5621101589a915a0f61340d6ee06d3c8
Cr-Commit-Position: refs/heads/master@{#14561}
Patch Set 1 #
Messages
Total messages: 20 (13 generated)
The CQ bit was checked by perkj@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
perkj@webrtc.org changed reviewers: + kjellander@webrtc.org, mflodman@webrtc.org
Needed for upstream projects...
Seems like it's unused, yes. lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/9035)
Description was changed from ========== Cleanup depencency unused dependency on video_capture_module ========== to ========== Cleanup depencency unused dependency on video_capture_module TBR=mflodman@webrtc.org ==========
Description was changed from ========== Cleanup depencency unused dependency on video_capture_module TBR=mflodman@webrtc.org ========== to ========== Cleanup unused dependency on video_capture_module. TBR=mflodman@webrtc.org ==========
The CQ bit was checked by perkj@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/9037)
Description was changed from ========== Cleanup unused dependency on video_capture_module. TBR=mflodman@webrtc.org ========== to ========== Cleanup unused dependency on video_capture_module. BUG=none TBR=mflodman@webrtc.org ==========
The CQ bit was checked by perkj@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Message was sent while issue was closed.
Description was changed from ========== Cleanup unused dependency on video_capture_module. BUG=none TBR=mflodman@webrtc.org ========== to ========== Cleanup unused dependency on video_capture_module. BUG=none TBR=mflodman@webrtc.org ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Cleanup unused dependency on video_capture_module. BUG=none TBR=mflodman@webrtc.org ========== to ========== Cleanup unused dependency on video_capture_module. BUG=none TBR=mflodman@webrtc.org Committed: https://crrev.com/ae04e36f5621101589a915a0f61340d6ee06d3c8 Cr-Commit-Position: refs/heads/master@{#14561} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/ae04e36f5621101589a915a0f61340d6ee06d3c8 Cr-Commit-Position: refs/heads/master@{#14561} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
