Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 2401603003: Reland of https://codereview.webrtc.org/2396483002/ (Closed)

Created:
4 years, 2 months ago by aleloi
Modified:
4 years, 2 months ago
Reviewers:
ivoc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, hlundin-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of https://codereview.webrtc.org/2396483002/ LOG_T_F macro is not defined for chromium builds. NOTRY=True BUG=webrtc:6346 TBR=ivoc@webrtc.org Committed: https://crrev.com/36542514f6a0738d0322647ccc920f2a0ba19c01 Cr-Commit-Position: refs/heads/master@{#14569}

Patch Set 1 : Previous CL https://codereview.webrtc.org/2396483002/ #

Patch Set 2 : Changed LOG macro. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+180 lines, -164 lines) Patch
M webrtc/modules/audio_mixer/BUILD.gn View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/modules/audio_mixer/audio_frame_manipulator.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_mixer/audio_frame_manipulator.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_mixer/audio_mixer.gypi View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/modules/audio_mixer/audio_mixer_defines.h View 2 chunks +2 lines, -19 lines 0 comments Download
D webrtc/modules/audio_mixer/audio_mixer_defines.cc View 1 chunk +0 lines, -38 lines 0 comments Download
M webrtc/modules/audio_mixer/audio_mixer_impl.h View 4 chunks +10 lines, -9 lines 0 comments Download
M webrtc/modules/audio_mixer/audio_mixer_impl.cc View 1 16 chunks +90 lines, -75 lines 0 comments Download
A webrtc/modules/audio_mixer/audio_source_with_mix_status.h View 1 chunk +45 lines, -0 lines 0 comments Download
A + webrtc/modules/audio_mixer/audio_source_with_mix_status.cc View 1 chunk +13 lines, -8 lines 0 comments Download
M webrtc/modules/audio_mixer/test/audio_mixer_unittest.cc View 8 chunks +13 lines, -10 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
aleloi
4 years, 2 months ago (2016-10-07 12:19:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2401603003/20001
4 years, 2 months ago (2016-10-07 12:20:16 UTC) #6
ivoc
lgtm
4 years, 2 months ago (2016-10-07 12:21:27 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-07 12:28:35 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 12:28:43 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/36542514f6a0738d0322647ccc920f2a0ba19c01
Cr-Commit-Position: refs/heads/master@{#14569}

Powered by Google App Engine
This is Rietveld 408576698