Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2401393002: Prep to remove APM-related #defines from voice_engine_configurations.h (Closed)

Created:
4 years, 2 months ago by hlundin-webrtc
Modified:
4 years, 2 months ago
Reviewers:
the sun
CC:
webrtc-reviews_webrtc.org, henrika_webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, peah-webrtc, minyue-webrtc, the sun
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Prep to remove APM-related #defines from voice_engine_configurations.h Make sure that WEBRTC_VOICE_ENGINE_AGC, WEBRTC_VOICE_ENGINE_ECHO, and WEBRTC_VOICE_ENGINE_NR are always defined. BUG=webrtc:6506 Committed: https://crrev.com/ae0b3338e3748b2826016355e24a67477798b381 Cr-Commit-Position: refs/heads/master@{#14587}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M webrtc/voice_engine/voe_audio_processing_impl.cc View 14 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
hlundin-webrtc
Solenberg, PTAL. If this lands without breaking any downstream dependencies, I will go ahead and ...
4 years, 2 months ago (2016-10-10 13:49:45 UTC) #7
the sun
lgtm Can you change the #ifdef:s to #if:s?
4 years, 2 months ago (2016-10-10 14:00:25 UTC) #8
hlundin-webrtc
On 2016/10/10 14:00:25, the sun wrote: > lgtm > > Can you change the #ifdef:s ...
4 years, 2 months ago (2016-10-10 14:14:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2401393002/20001
4 years, 2 months ago (2016-10-10 14:15:39 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 2 months ago (2016-10-10 14:24:56 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-10 14:25:05 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ae0b3338e3748b2826016355e24a67477798b381
Cr-Commit-Position: refs/heads/master@{#14587}

Powered by Google App Engine
This is Rietveld 408576698