Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2401033002: iOS: Fix rotation bug for back camera (Closed)

Created:
4 years, 2 months ago by magjed_webrtc
Modified:
4 years, 2 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

iOS: Fix rotation bug for back camera The rotation is currently incorrect for the back camera in landscape mode. The reason is that device rotation needs to be reversed for the back camera compared to the front camera. The camera sensor can also be mounted with a specific orientation. So when front camera rotation goes through: 0->90->180->270, back camera rotation goes in reverse: 180->90->0->270. BUG=b/31984246,b/30651939 Committed: https://crrev.com/9e31cca8f49cddab997843ffb8a62df7af9cad78 Cr-Commit-Position: refs/heads/master@{#14580}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M webrtc/sdk/objc/Framework/Classes/avfoundationvideocapturer.mm View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
magjed_webrtc
Please take a look.
4 years, 2 months ago (2016-10-07 14:33:30 UTC) #4
Chuck
lgtm
4 years, 2 months ago (2016-10-07 14:41:03 UTC) #6
daniela-webrtc
lgtm
4 years, 2 months ago (2016-10-07 14:44:37 UTC) #7
tkchin_webrtc
On 2016/10/07 14:44:37, denicija-webrtc wrote: > lgtm lgtm
4 years, 2 months ago (2016-10-07 19:55:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2401033002/1
4 years, 2 months ago (2016-10-08 09:25:41 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-08 09:57:55 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-08 09:57:59 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9e31cca8f49cddab997843ffb8a62df7af9cad78
Cr-Commit-Position: refs/heads/master@{#14580}

Powered by Google App Engine
This is Rietveld 408576698