Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2400953002: Revert of Add support for component builds on Windows Swarming. (Closed)

Created:
4 years, 2 months ago by ehmaldonado_webrtc
Modified:
4 years, 2 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Add support for component builds on Windows Swarming. (patchset #2 id:100001 of https://codereview.webrtc.org/2389133002/ ) Reason for revert: Causes errors when generating build files. https://build.chromium.org/p/client.webrtc/builders/Mac64%20Debug/builds/8646/steps/generate_build_files/logs/stdio Original issue's description: > Add support for component builds on Windows Swarming. > > Some runtime dependencies on MSVC were missing and had to be added to rtc_base_approved. > > BUG=chromium:497757 > NOTRY=True > > Committed: https://crrev.com/66d4ce93244d17eb52a409dde036fe9114937651 > Cr-Commit-Position: refs/heads/master@{#14562} TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:497757

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -82 lines) Patch
M webrtc/base/BUILD.gn View 2 chunks +0 lines, -82 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
ehmaldonado_webrtc
Created Revert of Add support for component builds on Windows Swarming.
4 years, 2 months ago (2016-10-07 07:31:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2400953002/1
4 years, 2 months ago (2016-10-07 07:31:54 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-07 07:32:00 UTC) #5
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 07:32:09 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/23345594e0acb9e1857b2aee0652b96d461eefd1
Cr-Commit-Position: refs/heads/master@{#14563}

Powered by Google App Engine
This is Rietveld 408576698