Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Unified Diff: webrtc/modules/video_coding/packet_buffer.h

Issue 2399373002: Only advance |first_seq_num_| if packets are explicitly cleared from the PacketBuffer. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/video_coding/packet_buffer.h
diff --git a/webrtc/modules/video_coding/packet_buffer.h b/webrtc/modules/video_coding/packet_buffer.h
index 34a2d402bbbb24461a44dcd233264e86eef913bb..b9fb78207f297ae58b74be4174b741814bdbe5ea 100644
--- a/webrtc/modules/video_coding/packet_buffer.h
+++ b/webrtc/modules/video_coding/packet_buffer.h
@@ -94,7 +94,8 @@ class PacketBuffer {
bool ExpandBufferSize() EXCLUSIVE_LOCKS_REQUIRED(crit_);
// Test if all previous packets has arrived for the given sequence number.
- bool IsContinuous(uint16_t seq_num) const EXCLUSIVE_LOCKS_REQUIRED(crit_);
+ bool PotentialNewFrame(uint16_t seq_num) const
+ EXCLUSIVE_LOCKS_REQUIRED(crit_);
// Test if all packets of a frame has arrived, and if so, creates a frame.
// May create multiple frames per invocation.
@@ -127,6 +128,9 @@ class PacketBuffer {
// If the packet buffer has received its first packet.
bool first_packet_received_ GUARDED_BY(crit_);
+ // If the buffer is cleared to a specific packet.
danilchap 2016/10/07 18:25:37 can you write what packet it cleared to, to first_
philipel 2016/10/18 12:22:19 Done.
danilchap 2016/10/19 09:25:10 Can't see the difference.
philipel 2016/10/19 13:08:50 Double Done.
+ bool has_cleared_to_ GUARDED_BY(crit_);
+
// Buffer that holds the inserted packets.
std::vector<VCMPacket> data_buffer_ GUARDED_BY(crit_);
« no previous file with comments | « no previous file | webrtc/modules/video_coding/packet_buffer.cc » ('j') | webrtc/modules/video_coding/packet_buffer.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698