Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Unified Diff: webrtc/media/engine/videoencodersoftwarefallbackwrapper_unittest.cc

Issue 2398963003: Move usage of QualityScaler to ViEEncoder. (Closed)
Patch Set: rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/media/engine/videoencodersoftwarefallbackwrapper_unittest.cc
diff --git a/webrtc/media/engine/videoencodersoftwarefallbackwrapper_unittest.cc b/webrtc/media/engine/videoencodersoftwarefallbackwrapper_unittest.cc
index ca06e9256d67c843be61b7730d47675ced1b43b7..096552bbfa460e16e23a13e7759f3d982b3a30a3 100644
--- a/webrtc/media/engine/videoencodersoftwarefallbackwrapper_unittest.cc
+++ b/webrtc/media/engine/videoencodersoftwarefallbackwrapper_unittest.cc
@@ -74,8 +74,6 @@ class VideoEncoderSoftwareFallbackWrapperTest : public ::testing::Test {
return WEBRTC_VIDEO_CODEC_OK;
}
- void OnDroppedFrame() override { ++on_dropped_frame_count_; }
-
bool SupportsNativeHandle() const override {
++supports_native_handle_count_;
return false;
@@ -93,7 +91,6 @@ class VideoEncoderSoftwareFallbackWrapperTest : public ::testing::Test {
int release_count_ = 0;
int set_channel_parameters_count_ = 0;
int set_rates_count_ = 0;
- int on_dropped_frame_count_ = 0;
mutable int supports_native_handle_count_ = 0;
};
@@ -271,20 +268,6 @@ TEST_F(VideoEncoderSoftwareFallbackWrapperTest,
}
TEST_F(VideoEncoderSoftwareFallbackWrapperTest,
- OnDroppedFrameForwardedWithoutFallback) {
- fallback_wrapper_.OnDroppedFrame();
- EXPECT_EQ(1, fake_encoder_.on_dropped_frame_count_);
-}
-
-TEST_F(VideoEncoderSoftwareFallbackWrapperTest,
- OnDroppedFrameNotForwardedDuringFallback) {
- UtilizeFallbackEncoder();
- fallback_wrapper_.OnDroppedFrame();
- EXPECT_EQ(0, fake_encoder_.on_dropped_frame_count_);
- EXPECT_EQ(WEBRTC_VIDEO_CODEC_OK, fallback_wrapper_.Release());
-}
-
-TEST_F(VideoEncoderSoftwareFallbackWrapperTest,
SupportsNativeHandleForwardedWithoutFallback) {
fallback_wrapper_.SupportsNativeHandle();
EXPECT_EQ(1, fake_encoder_.supports_native_handle_count_);

Powered by Google App Engine
This is Rietveld 408576698