Move usage of QualityScaler to ViEEncoder.

webrtc/video/send_statistics_proxy_unittest.cc

Index: webrtc/video/send_statistics_proxy_unittest.cc
diff --git a/webrtc/video/send_statistics_proxy_unittest.cc b/webrtc/video/send_statistics_proxy_unittest.cc
index a467f6c5d102aeb75dc1c16449b3eed45fa60d9e..e390268b5ae68313462a7a94f21021f5abb083c2 100644
--- a/webrtc/video/send_statistics_proxy_unittest.cc
+++ b/webrtc/video/send_statistics_proxy_unittest.cc
@@ -603,22 +603,10 @@ TEST_F(SendStatisticsProxyTest, GetStatsReportsBandwidthLimitedResolution) {
   EXPECT_FALSE(statistics_proxy_->GetStats().bw_limited_resolution);
   // Resolution not scaled.
   encoded_image.adapt_reason_.bw_resolutions_disabled = 0;
-  encoded_image.adapt_reason_.quality_resolution_downscales = 0;
   statistics_proxy_->OnSendEncodedImage(encoded_image, nullptr);
   EXPECT_FALSE(statistics_proxy_->GetStats().bw_limited_resolution);
   // Resolution scaled due to bandwidth.
   encoded_image.adapt_reason_.bw_resolutions_disabled = 1;
-  encoded_image.adapt_reason_.quality_resolution_downscales = 0;
-  statistics_proxy_->OnSendEncodedImage(encoded_image, nullptr);
-  EXPECT_TRUE(statistics_proxy_->GetStats().bw_limited_resolution);
-  // Resolution not scaled.
-  encoded_image.adapt_reason_.bw_resolutions_disabled = 0;
-  encoded_image.adapt_reason_.quality_resolution_downscales = 0;
-  statistics_proxy_->OnSendEncodedImage(encoded_image, nullptr);
-  EXPECT_FALSE(statistics_proxy_->GetStats().bw_limited_resolution);
-  // Resolution scaled due to quality.
-  encoded_image.adapt_reason_.bw_resolutions_disabled = 0;
-  encoded_image.adapt_reason_.quality_resolution_downscales = 1;

[perkj_webrtc, 2016/11/14 07:21:16]

So GetStats previously reported bw_limited_resolution when quality scaling
kicked in.  I guess that make sense since if bw had been enough the quality
should be good enough. 
So please make sure this behaviour is not changed or start a discussion with
Åsa, Stefan and Pbos. 

[sprang_webrtc, 2016/11/14 10:25:39]

+1, so you don't get this reverted because of a perceived stats regression.

[kthelgason, 2016/11/14 14:36:44]

This behaviour has not changed, only how it's reported. This used to be done via
a hack, setting this property on the |encoded_image| that eventually finds it's
way to the stats proxy. This was necessary because scaling happened all the way
down in the encoders. Now we can just report this directly to the stats_proxy
without having to stick a note on the frame. 

   statistics_proxy_->OnSendEncodedImage(encoded_image, nullptr);
   EXPECT_TRUE(statistics_proxy_->GetStats().bw_limited_resolution);
 }