Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1130)

Unified Diff: webrtc/video/send_statistics_proxy_unittest.cc

Issue 2398963003: Move usage of QualityScaler to ViEEncoder. (Closed)
Patch Set: Stats now properly reflect scaling status Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/video/send_statistics_proxy_unittest.cc
diff --git a/webrtc/video/send_statistics_proxy_unittest.cc b/webrtc/video/send_statistics_proxy_unittest.cc
index e6d4ed67df06fd1fde2d65ffc1ec1168dc38f190..05dbc56d1b795d909797aaa9466528488f935105 100644
--- a/webrtc/video/send_statistics_proxy_unittest.cc
+++ b/webrtc/video/send_statistics_proxy_unittest.cc
@@ -305,7 +305,7 @@ TEST_F(SendStatisticsProxyTest, SwitchContentTypeUpdatesHistograms) {
const int kHeight = 480;
for (int i = 0; i < SendStatisticsProxy::kMinRequiredUMASamples; ++i)
- statistics_proxy_->OnIncomingFrame(kWidth, kHeight, false);
+ statistics_proxy_->OnIncomingFrame(kWidth, kHeight);
// No switch, stats should not be updated.
VideoEncoderConfig config;
@@ -324,10 +324,12 @@ TEST_F(SendStatisticsProxyTest, CpuLimitedResolutionUpdated) {
const int kHeight = 480;
for (int i = 0; i < SendStatisticsProxy::kMinRequiredUMASamples; ++i)
- statistics_proxy_->OnIncomingFrame(kWidth, kHeight, false);
+ statistics_proxy_->OnIncomingFrame(kWidth, kHeight);
+
+ statistics_proxy_->OnCpuRestrictedResolutionChanged(true);
for (int i = 0; i < SendStatisticsProxy::kMinRequiredUMASamples; ++i)
- statistics_proxy_->OnIncomingFrame(kWidth, kHeight, true);
+ statistics_proxy_->OnIncomingFrame(kWidth, kHeight);
statistics_proxy_.reset();
EXPECT_EQ(1,

Powered by Google App Engine
This is Rietveld 408576698