Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Unified Diff: webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter.cc

Issue 2398963003: Move usage of QualityScaler to ViEEncoder. (Closed)
Patch Set: Stats now properly reflect scaling status Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter.cc
diff --git a/webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter.cc b/webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter.cc
index 1c8037a60e9ce4657a146cd0ba888798e416ac40..7fa198b4a5f6bf8b584d325dcff4ec438a0dab9b 100644
--- a/webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter.cc
+++ b/webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter.cc
@@ -471,6 +471,15 @@ bool SimulcastEncoderAdapter::SupportsNativeHandle() const {
return true;
}
+QualityScaler::Settings SimulcastEncoderAdapter::GetQPThresholds() const {
+ // Turn off quality scaling for simulcast
+ RTC_DCHECK(!streaminfos_.empty()) << "Encoder must be initialized first.";
magjed_webrtc 2016/10/26 14:28:36 Is it a security risk if we execute streaminfos_[0
kthelgason 2016/10/26 19:02:49 Done.
+ if (NumberOfStreams(codec_) > 1)
+ return QualityScaler::Settings(false);
+ else
+ return streaminfos_[0].encoder->GetQPThresholds();
+}
+
const char* SimulcastEncoderAdapter::ImplementationName() const {
return implementation_name_.c_str();
}

Powered by Google App Engine
This is Rietveld 408576698