Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Side by Side Diff: webrtc/video/vie_encoder.h

Issue 2398963003: Move usage of QualityScaler to ViEEncoder. (Closed)
Patch Set: Code review Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #ifndef WEBRTC_VIDEO_VIE_ENCODER_H_ 11 #ifndef WEBRTC_VIDEO_VIE_ENCODER_H_
12 #define WEBRTC_VIDEO_VIE_ENCODER_H_ 12 #define WEBRTC_VIDEO_VIE_ENCODER_H_
13 13
14 #include <memory> 14 #include <memory>
15 #include <string> 15 #include <string>
16 #include <vector> 16 #include <vector>
17 17
18 #include "webrtc/base/criticalsection.h" 18 #include "webrtc/base/criticalsection.h"
19 #include "webrtc/base/event.h" 19 #include "webrtc/base/event.h"
20 #include "webrtc/base/sequenced_task_checker.h" 20 #include "webrtc/base/sequenced_task_checker.h"
21 #include "webrtc/base/task_queue.h" 21 #include "webrtc/base/task_queue.h"
22 #include "webrtc/call.h" 22 #include "webrtc/call.h"
23 #include "webrtc/common_types.h" 23 #include "webrtc/common_types.h"
24 #include "webrtc/common_video/include/video_bitrate_allocator.h" 24 #include "webrtc/common_video/include/video_bitrate_allocator.h"
25 #include "webrtc/common_video/rotation.h" 25 #include "webrtc/common_video/rotation.h"
26 #include "webrtc/media/base/videosinkinterface.h" 26 #include "webrtc/media/base/videosinkinterface.h"
27 #include "webrtc/modules/video_coding/include/video_coding_defines.h" 27 #include "webrtc/modules/video_coding/include/video_coding_defines.h"
28 #include "webrtc/modules/video_coding/utility/quality_scaler.h"
28 #include "webrtc/modules/video_coding/video_coding_impl.h" 29 #include "webrtc/modules/video_coding/video_coding_impl.h"
29 #include "webrtc/modules/video_processing/include/video_processing.h" 30 #include "webrtc/modules/video_processing/include/video_processing.h"
30 #include "webrtc/system_wrappers/include/atomic32.h" 31 #include "webrtc/system_wrappers/include/atomic32.h"
31 #include "webrtc/video/overuse_frame_detector.h" 32 #include "webrtc/video/overuse_frame_detector.h"
32 #include "webrtc/video_encoder.h" 33 #include "webrtc/video_encoder.h"
33 #include "webrtc/video_send_stream.h" 34 #include "webrtc/video_send_stream.h"
34 #include "webrtc/typedefs.h" 35 #include "webrtc/typedefs.h"
35 36
36 namespace webrtc { 37 namespace webrtc {
37 38
38 class ProcessThread; 39 class ProcessThread;
39 class SendStatisticsProxy; 40 class SendStatisticsProxy;
40 41
41 // VieEncoder represent a video encoder that accepts raw video frames as input 42 // VieEncoder represent a video encoder that accepts raw video frames as input
42 // and produces an encoded bit stream. 43 // and produces an encoded bit stream.
43 // Usage: 44 // Usage:
44 // Instantiate. 45 // Instantiate.
45 // Call SetSink. 46 // Call SetSink.
46 // Call SetSource. 47 // Call SetSource.
47 // Call ConfigureEncoder with the codec settings. 48 // Call ConfigureEncoder with the codec settings.
48 // Call Stop() when done. 49 // Call Stop() when done.
49 class ViEEncoder : public rtc::VideoSinkInterface<VideoFrame>, 50 class ViEEncoder : public rtc::VideoSinkInterface<VideoFrame>,
50 public EncodedImageCallback, 51 public EncodedImageCallback,
51 public VCMSendStatisticsCallback, 52 public VCMSendStatisticsCallback,
52 public CpuOveruseObserver { 53 public ScalingObserverInterface {
53 public: 54 public:
54 // Interface for receiving encoded video frames and notifications about 55 // Interface for receiving encoded video frames and notifications about
55 // configuration changes. 56 // configuration changes.
56 class EncoderSink : public EncodedImageCallback { 57 class EncoderSink : public EncodedImageCallback {
57 public: 58 public:
58 virtual void OnEncoderConfigurationChanged( 59 virtual void OnEncoderConfigurationChanged(
59 std::vector<VideoStream> streams, 60 std::vector<VideoStream> streams,
60 int min_transmit_bitrate_bps) = 0; 61 int min_transmit_bitrate_bps) = 0;
61 }; 62 };
62 63
63 // Down grade resolution at most 2 times for CPU reasons. 64 // Downscale resolution at most 2 times for CPU reasons.
64 static const int kMaxCpuDowngrades = 2; 65 static const int kMaxCpuDowngrades = 2;
66 // Downscale resolution at most 2 times for low-quality reasons.
67 static const int kMaxQualityDowngrades = 2;
65 68
66 ViEEncoder(uint32_t number_of_cores, 69 ViEEncoder(uint32_t number_of_cores,
67 SendStatisticsProxy* stats_proxy, 70 SendStatisticsProxy* stats_proxy,
68 const VideoSendStream::Config::EncoderSettings& settings, 71 const VideoSendStream::Config::EncoderSettings& settings,
69 rtc::VideoSinkInterface<VideoFrame>* pre_encode_callback, 72 rtc::VideoSinkInterface<VideoFrame>* pre_encode_callback,
70 EncodedFrameObserver* encoder_timing); 73 EncodedFrameObserver* encoder_timing);
71 ~ViEEncoder(); 74 ~ViEEncoder();
72 // RegisterProcessThread register |module_process_thread| with those objects 75 // RegisterProcessThread register |module_process_thread| with those objects
73 // that use it. Registration has to happen on the thread where 76 // that use it. Registration has to happen on the thread where
74 // |module_process_thread| was created (libjingle's worker thread). 77 // |module_process_thread| was created (libjingle's worker thread).
(...skipping 28 matching lines...) Expand all
103 // virtual to test EncoderStateFeedback with mocks. 106 // virtual to test EncoderStateFeedback with mocks.
104 virtual void OnReceivedIntraFrameRequest(size_t stream_index); 107 virtual void OnReceivedIntraFrameRequest(size_t stream_index);
105 virtual void OnReceivedSLI(uint8_t picture_id); 108 virtual void OnReceivedSLI(uint8_t picture_id);
106 virtual void OnReceivedRPSI(uint64_t picture_id); 109 virtual void OnReceivedRPSI(uint64_t picture_id);
107 110
108 void OnBitrateUpdated(uint32_t bitrate_bps, 111 void OnBitrateUpdated(uint32_t bitrate_bps,
109 uint8_t fraction_lost, 112 uint8_t fraction_lost,
110 int64_t round_trip_time_ms); 113 int64_t round_trip_time_ms);
111 114
112 protected: 115 protected:
113 // Used for testing. For example the |CpuOveruseObserver| methods must be 116 // Used for testing. For example the |ScalingObserverInterface| methods must
114 // called on |encoder_queue_|. 117 // be called on |encoder_queue_|.
115 rtc::TaskQueue* encoder_queue() { return &encoder_queue_; } 118 rtc::TaskQueue* encoder_queue() { return &encoder_queue_; }
116 119
117 // webrtc::CpuOveruseObserver implementation. 120 // webrtc::ScalingObserverInterface implementation.
118 // These methods are protected for easier testing. 121 // These methods are protected for easier testing.
119 void OveruseDetected() override; 122 void ScaleUp(ScaleReason reason) override;
120 void NormalUsage() override; 123 void ScaleDown(ScaleReason reason) override;
121 124
122 private: 125 private:
123 class ConfigureEncoderTask; 126 class ConfigureEncoderTask;
124 class EncodeTask; 127 class EncodeTask;
125 class VideoSourceProxy; 128 class VideoSourceProxy;
126 129
127 struct VideoFrameInfo { 130 struct VideoFrameInfo {
128 VideoFrameInfo(int width, 131 VideoFrameInfo(int width,
129 int height, 132 int height,
130 VideoRotation rotation, 133 VideoRotation rotation,
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
167 170
168 const uint32_t number_of_cores_; 171 const uint32_t number_of_cores_;
169 172
170 const std::unique_ptr<VideoSourceProxy> source_proxy_; 173 const std::unique_ptr<VideoSourceProxy> source_proxy_;
171 EncoderSink* sink_; 174 EncoderSink* sink_;
172 const VideoSendStream::Config::EncoderSettings settings_; 175 const VideoSendStream::Config::EncoderSettings settings_;
173 const VideoCodecType codec_type_; 176 const VideoCodecType codec_type_;
174 177
175 vcm::VideoSender video_sender_ ACCESS_ON(&encoder_queue_); 178 vcm::VideoSender video_sender_ ACCESS_ON(&encoder_queue_);
176 OveruseFrameDetector overuse_detector_ ACCESS_ON(&encoder_queue_); 179 OveruseFrameDetector overuse_detector_ ACCESS_ON(&encoder_queue_);
180 std::unique_ptr<QualityScaler> quality_scaler_ ACCESS_ON(&encoder_queue_);
177 181
178 SendStatisticsProxy* const stats_proxy_; 182 SendStatisticsProxy* const stats_proxy_;
179 rtc::VideoSinkInterface<VideoFrame>* const pre_encode_callback_; 183 rtc::VideoSinkInterface<VideoFrame>* const pre_encode_callback_;
180 ProcessThread* module_process_thread_; 184 ProcessThread* module_process_thread_;
181 rtc::ThreadChecker module_process_thread_checker_; 185 rtc::ThreadChecker module_process_thread_checker_;
182 // |thread_checker_| checks that public methods that are related to lifetime 186 // |thread_checker_| checks that public methods that are related to lifetime
183 // of ViEEncoder are called on the same thread. 187 // of ViEEncoder are called on the same thread.
184 rtc::ThreadChecker thread_checker_; 188 rtc::ThreadChecker thread_checker_;
185 189
186 VideoEncoderConfig encoder_config_ ACCESS_ON(&encoder_queue_); 190 VideoEncoderConfig encoder_config_ ACCESS_ON(&encoder_queue_);
187 std::unique_ptr<VideoBitrateAllocator> rate_allocator_ 191 std::unique_ptr<VideoBitrateAllocator> rate_allocator_
188 ACCESS_ON(&encoder_queue_); 192 ACCESS_ON(&encoder_queue_);
189 193
190 // Set when ConfigureEncoder has been called in order to lazy reconfigure the 194 // Set when ConfigureEncoder has been called in order to lazy reconfigure the
191 // encoder on the next frame. 195 // encoder on the next frame.
192 bool pending_encoder_reconfiguration_ ACCESS_ON(&encoder_queue_); 196 bool pending_encoder_reconfiguration_ ACCESS_ON(&encoder_queue_);
193 rtc::Optional<VideoFrameInfo> last_frame_info_ ACCESS_ON(&encoder_queue_); 197 rtc::Optional<VideoFrameInfo> last_frame_info_ ACCESS_ON(&encoder_queue_);
194 uint32_t encoder_start_bitrate_bps_ ACCESS_ON(&encoder_queue_); 198 uint32_t encoder_start_bitrate_bps_ ACCESS_ON(&encoder_queue_);
195 size_t max_data_payload_length_ ACCESS_ON(&encoder_queue_); 199 size_t max_data_payload_length_ ACCESS_ON(&encoder_queue_);
196 uint32_t last_observed_bitrate_bps_ ACCESS_ON(&encoder_queue_); 200 uint32_t last_observed_bitrate_bps_ ACCESS_ON(&encoder_queue_);
197 bool encoder_paused_and_dropped_frame_ ACCESS_ON(&encoder_queue_); 201 bool encoder_paused_and_dropped_frame_ ACCESS_ON(&encoder_queue_);
198 bool has_received_sli_ ACCESS_ON(&encoder_queue_); 202 bool has_received_sli_ ACCESS_ON(&encoder_queue_);
199 uint8_t picture_id_sli_ ACCESS_ON(&encoder_queue_); 203 uint8_t picture_id_sli_ ACCESS_ON(&encoder_queue_);
200 bool has_received_rpsi_ ACCESS_ON(&encoder_queue_); 204 bool has_received_rpsi_ ACCESS_ON(&encoder_queue_);
201 uint64_t picture_id_rpsi_ ACCESS_ON(&encoder_queue_); 205 uint64_t picture_id_rpsi_ ACCESS_ON(&encoder_queue_);
202 Clock* const clock_; 206 Clock* const clock_;
203 207 // Counters used for deciding if the video resolution is currently
204 VideoSendStream::DegradationPreference degradation_preference_ 208 // restricted, and if so, why.
205 ACCESS_ON(&encoder_queue_); 209 int scale_counter_[kScaleReasonSize] ACCESS_ON(&encoder_queue_) = {0};
206 // Counter used for deciding if the video resolution is currently 210 // Set depending on degradation preferences
207 // restricted by CPU usage. 211 bool scaling_enabled_ ACCESS_ON(&encoder_queue_) = false;
208 int cpu_restricted_counter_ ACCESS_ON(&encoder_queue_);
209 212
210 int last_frame_width_ ACCESS_ON(&encoder_queue_); 213 int last_frame_width_ ACCESS_ON(&encoder_queue_);
211 int last_frame_height_ ACCESS_ON(&encoder_queue_); 214 int last_frame_height_ ACCESS_ON(&encoder_queue_);
212 // Pixel count last time the resolution was requested to be changed down. 215 // Pixel count last time the resolution was requested to be changed down.
213 rtc::Optional<int> max_pixel_count_ ACCESS_ON(&encoder_queue_); 216 rtc::Optional<int> max_pixel_count_ ACCESS_ON(&encoder_queue_);
214 // Pixel count last time the resolution was requested to be changed up. 217 // Pixel count last time the resolution was requested to be changed up.
215 rtc::Optional<int> max_pixel_count_step_up_ ACCESS_ON(&encoder_queue_); 218 rtc::Optional<int> max_pixel_count_step_up_ ACCESS_ON(&encoder_queue_);
216 219
217 rtc::RaceChecker incoming_frame_race_checker_ 220 rtc::RaceChecker incoming_frame_race_checker_
218 GUARDED_BY(incoming_frame_race_checker_); 221 GUARDED_BY(incoming_frame_race_checker_);
(...skipping 10 matching lines...) Expand all
229 // All public methods are proxied to |encoder_queue_|. It must must be 232 // All public methods are proxied to |encoder_queue_|. It must must be
230 // destroyed first to make sure no tasks are run that use other members. 233 // destroyed first to make sure no tasks are run that use other members.
231 rtc::TaskQueue encoder_queue_; 234 rtc::TaskQueue encoder_queue_;
232 235
233 RTC_DISALLOW_COPY_AND_ASSIGN(ViEEncoder); 236 RTC_DISALLOW_COPY_AND_ASSIGN(ViEEncoder);
234 }; 237 };
235 238
236 } // namespace webrtc 239 } // namespace webrtc
237 240
238 #endif // WEBRTC_VIDEO_VIE_ENCODER_H_ 241 #endif // WEBRTC_VIDEO_VIE_ENCODER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698