Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Side by Side Diff: webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter.cc

Issue 2398963003: Move usage of QualityScaler to ViEEncoder. (Closed)
Patch Set: prevent data race Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2014 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 447 matching lines...) Expand 10 before | Expand all | Expand 10 after
458 bool SimulcastEncoderAdapter::SupportsNativeHandle() const { 458 bool SimulcastEncoderAdapter::SupportsNativeHandle() const {
459 // We should not be calling this method before streaminfos_ are configured. 459 // We should not be calling this method before streaminfos_ are configured.
460 RTC_DCHECK(!streaminfos_.empty()); 460 RTC_DCHECK(!streaminfos_.empty());
461 for (const auto& streaminfo : streaminfos_) { 461 for (const auto& streaminfo : streaminfos_) {
462 if (!streaminfo.encoder->SupportsNativeHandle()) 462 if (!streaminfo.encoder->SupportsNativeHandle())
463 return false; 463 return false;
464 } 464 }
465 return true; 465 return true;
466 } 466 }
467 467
468 VideoEncoder::ScalingSettings SimulcastEncoderAdapter::GetScalingSettings()
469 const {
470 // Turn off quality scaling for simulcast.
471 if (NumberOfStreams(codec_) == 1) {
472 return streaminfos_[0].encoder->GetScalingSettings();
473 } else {
stefan-webrtc 2016/11/17 16:12:57 I'd rewrite this: if (NumberOfStreams(codec_) !=
kthelgason 2016/11/21 13:06:52 Done.
474 return VideoEncoder::ScalingSettings(false);
475 }
476 }
477
468 const char* SimulcastEncoderAdapter::ImplementationName() const { 478 const char* SimulcastEncoderAdapter::ImplementationName() const {
469 return implementation_name_.c_str(); 479 return implementation_name_.c_str();
470 } 480 }
471 481
472 } // namespace webrtc 482 } // namespace webrtc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698