Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Side by Side Diff: webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter.cc

Issue 2398963003: Move usage of QualityScaler to ViEEncoder. (Closed)
Patch Set: Code review Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2014 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 453 matching lines...) Expand 10 before | Expand all | Expand 10 after
464 bool SimulcastEncoderAdapter::SupportsNativeHandle() const { 464 bool SimulcastEncoderAdapter::SupportsNativeHandle() const {
465 // We should not be calling this method before streaminfos_ are configured. 465 // We should not be calling this method before streaminfos_ are configured.
466 RTC_DCHECK(!streaminfos_.empty()); 466 RTC_DCHECK(!streaminfos_.empty());
467 for (const auto& streaminfo : streaminfos_) { 467 for (const auto& streaminfo : streaminfos_) {
468 if (!streaminfo.encoder->SupportsNativeHandle()) 468 if (!streaminfo.encoder->SupportsNativeHandle())
469 return false; 469 return false;
470 } 470 }
471 return true; 471 return true;
472 } 472 }
473 473
474 QualityScaler::Settings SimulcastEncoderAdapter::GetQPThresholds() const {
475 // Turn off quality scaling for simulcast
sprang_webrtc 2016/10/27 13:43:48 nit: End comments with a period.
kthelgason 2016/10/28 13:20:14 Done.
476 if (NumberOfStreams(codec_) == 1)
477 return streaminfos_[0].encoder->GetQPThresholds();
478 else
479 return QualityScaler::Settings(false);
sprang_webrtc 2016/10/27 13:43:48 nit: use {} brackets with if+else even if single l
kthelgason 2016/10/28 13:20:14 Done.
480 }
481
474 const char* SimulcastEncoderAdapter::ImplementationName() const { 482 const char* SimulcastEncoderAdapter::ImplementationName() const {
475 return implementation_name_.c_str(); 483 return implementation_name_.c_str();
476 } 484 }
477 485
478 } // namespace webrtc 486 } // namespace webrtc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698