Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Side by Side Diff: webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_encoder.h

Issue 2398963003: Move usage of QualityScaler to ViEEncoder. (Closed)
Patch Set: Code review comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 * 9 *
10 */ 10 */
11 11
12 #ifndef WEBRTC_MODULES_VIDEO_CODING_CODECS_H264_H264_VIDEO_TOOLBOX_ENCODER_H_ 12 #ifndef WEBRTC_MODULES_VIDEO_CODING_CODECS_H264_H264_VIDEO_TOOLBOX_ENCODER_H_
13 #define WEBRTC_MODULES_VIDEO_CODING_CODECS_H264_H264_VIDEO_TOOLBOX_ENCODER_H_ 13 #define WEBRTC_MODULES_VIDEO_CODING_CODECS_H264_H264_VIDEO_TOOLBOX_ENCODER_H_
14 14
15 #include "webrtc/base/criticalsection.h" 15 #include "webrtc/base/criticalsection.h"
16 #include "webrtc/common_video/include/bitrate_adjuster.h" 16 #include "webrtc/common_video/include/bitrate_adjuster.h"
17 #include "webrtc/common_video/rotation.h" 17 #include "webrtc/common_video/rotation.h"
18 #include "webrtc/modules/video_coding/codecs/h264/include/h264.h" 18 #include "webrtc/modules/video_coding/codecs/h264/include/h264.h"
19 #include "webrtc/modules/video_coding/utility/h264_bitstream_parser.h" 19 #include "webrtc/modules/video_coding/utility/h264_bitstream_parser.h"
20 #include "webrtc/modules/video_coding/utility/quality_scaler.h"
21 20
22 #if defined(WEBRTC_VIDEO_TOOLBOX_SUPPORTED) 21 #if defined(WEBRTC_VIDEO_TOOLBOX_SUPPORTED)
23 22
24 #include <VideoToolbox/VideoToolbox.h> 23 #include <VideoToolbox/VideoToolbox.h>
25 #include <vector> 24 #include <vector>
26 25
27 // This file provides a H264 encoder implementation using the VideoToolbox 26 // This file provides a H264 encoder implementation using the VideoToolbox
28 // APIs. Since documentation is almost non-existent, this is largely based on 27 // APIs. Since documentation is almost non-existent, this is largely based on
29 // the information in the VideoToolbox header files, a talk from WWDC 2014 and 28 // the information in the VideoToolbox header files, a talk from WWDC 2014 and
30 // experimentation. 29 // experimentation.
31 30
32 namespace webrtc { 31 namespace webrtc {
33 32
34 class H264VideoToolboxEncoder : public H264Encoder { 33 class H264VideoToolboxEncoder : public H264Encoder {
35 public: 34 public:
36 H264VideoToolboxEncoder(); 35 H264VideoToolboxEncoder();
37 36
38 ~H264VideoToolboxEncoder() override; 37 ~H264VideoToolboxEncoder() override;
39 38
40 int InitEncode(const VideoCodec* codec_settings, 39 int InitEncode(const VideoCodec* codec_settings,
41 int number_of_cores, 40 int number_of_cores,
42 size_t max_payload_size) override; 41 size_t max_payload_size) override;
43 42
44 int Encode(const VideoFrame& input_image, 43 int Encode(const VideoFrame& input_image,
45 const CodecSpecificInfo* codec_specific_info, 44 const CodecSpecificInfo* codec_specific_info,
46 const std::vector<FrameType>* frame_types) override; 45 const std::vector<FrameType>* frame_types) override;
47 46
48 int RegisterEncodeCompleteCallback(EncodedImageCallback* callback) override; 47 int RegisterEncodeCompleteCallback(EncodedImageCallback* callback) override;
49 48
50 void OnDroppedFrame() override;
51 int SetChannelParameters(uint32_t packet_loss, int64_t rtt) override; 49 int SetChannelParameters(uint32_t packet_loss, int64_t rtt) override;
52 50
53 int SetRates(uint32_t new_bitrate_kbit, uint32_t frame_rate) override; 51 int SetRates(uint32_t new_bitrate_kbit, uint32_t frame_rate) override;
54 52
55 int Release() override; 53 int Release() override;
56 54
57 const char* ImplementationName() const override; 55 const char* ImplementationName() const override;
58 56
59 bool SupportsNativeHandle() const override; 57 bool SupportsNativeHandle() const override;
60 58
61 void OnEncodedFrame(OSStatus status, 59 void OnEncodedFrame(OSStatus status,
62 VTEncodeInfoFlags info_flags, 60 VTEncodeInfoFlags info_flags,
63 CMSampleBufferRef sample_buffer, 61 CMSampleBufferRef sample_buffer,
64 CodecSpecificInfo codec_specific_info, 62 CodecSpecificInfo codec_specific_info,
65 int32_t width, 63 int32_t width,
66 int32_t height, 64 int32_t height,
67 int64_t render_time_ms, 65 int64_t render_time_ms,
68 uint32_t timestamp, 66 uint32_t timestamp,
69 VideoRotation rotation); 67 VideoRotation rotation);
70 68
69 rtc::Optional<VideoEncoder::QPThresholds> GetQPThresholds() override;
70
71 private: 71 private:
72 int ResetCompressionSession(); 72 int ResetCompressionSession();
73 void ConfigureCompressionSession(); 73 void ConfigureCompressionSession();
74 void DestroyCompressionSession(); 74 void DestroyCompressionSession();
75 rtc::scoped_refptr<VideoFrameBuffer> GetScaledBufferOnEncode( 75 rtc::scoped_refptr<VideoFrameBuffer> GetScaledBufferOnEncode(
76 const rtc::scoped_refptr<VideoFrameBuffer>& frame); 76 const rtc::scoped_refptr<VideoFrameBuffer>& frame);
77 void SetBitrateBps(uint32_t bitrate_bps); 77 void SetBitrateBps(uint32_t bitrate_bps);
78 void SetEncoderBitrateBps(uint32_t bitrate_bps); 78 void SetEncoderBitrateBps(uint32_t bitrate_bps);
79 79
80 EncodedImageCallback* callback_; 80 EncodedImageCallback* callback_;
81 VTCompressionSessionRef compression_session_; 81 VTCompressionSessionRef compression_session_;
82 BitrateAdjuster bitrate_adjuster_; 82 BitrateAdjuster bitrate_adjuster_;
83 uint32_t target_bitrate_bps_; 83 uint32_t target_bitrate_bps_;
84 uint32_t encoder_bitrate_bps_; 84 uint32_t encoder_bitrate_bps_;
85 int32_t width_; 85 int32_t width_;
86 int32_t height_; 86 int32_t height_;
87 87
88 rtc::CriticalSection quality_scaler_crit_;
89 QualityScaler quality_scaler_ GUARDED_BY(quality_scaler_crit_);
90 H264BitstreamParser h264_bitstream_parser_; 88 H264BitstreamParser h264_bitstream_parser_;
91 bool enable_scaling_;
92 }; // H264VideoToolboxEncoder 89 }; // H264VideoToolboxEncoder
93 90
94 } // namespace webrtc 91 } // namespace webrtc
95 92
96 #endif // defined(WEBRTC_VIDEO_TOOLBOX_SUPPORTED) 93 #endif // defined(WEBRTC_VIDEO_TOOLBOX_SUPPORTED)
97 #endif // WEBRTC_MODULES_VIDEO_CODING_CODECS_H264_H264_VIDEO_TOOLBOX_ENCODER_H_ 94 #endif // WEBRTC_MODULES_VIDEO_CODING_CODECS_H264_H264_VIDEO_TOOLBOX_ENCODER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698