Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(677)

Issue 2398123002: Make bwe_simulator a separate test target that doesnt run on the bots (Closed)

Created:
4 years, 2 months ago by terelius
Modified:
4 years, 2 months ago
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), zhuangzesen_agora.io, stefan-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Make bwe_simulator a separate test target that doesnt run on the bots but remove the #if BWE_TEST_LOGGING_COMPILE_TIME_ENABLE so that it always builds. BUG=webrtc:6497 Committed: https://crrev.com/3dcfd64c2606aa40d16a64af54ebd718dcb1dfdb Cr-Commit-Position: refs/heads/master@{#14564}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -7 lines) Patch
M webrtc/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/BUILD.gn View 3 chunks +34 lines, -2 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/bwe_simulations.cc View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
terelius
4 years, 2 months ago (2016-10-06 16:14:19 UTC) #2
stefan-webrtc
lgtm
4 years, 2 months ago (2016-10-06 16:23:55 UTC) #3
kjellander_webrtc
lgtm
4 years, 2 months ago (2016-10-07 07:15:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2398123002/1
4 years, 2 months ago (2016-10-07 07:38:44 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-07 07:39:59 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3dcfd64c2606aa40d16a64af54ebd718dcb1dfdb Cr-Commit-Position: refs/heads/master@{#14564}
4 years, 2 months ago (2016-10-07 07:40:08 UTC) #9
Andrew44e
4 years, 2 months ago (2016-10-07 08:38:20 UTC) #10
Message was sent while issue was closed.
How is that going to be when #if BWE_TEST_LOGGING_COMPILE_TIME_ENABLE is
removed? 
Andrew
Checked in from http://domyhomeworkonline.net/ dashboard. c++ tools are not
installed yet.

Powered by Google App Engine
This is Rietveld 408576698