Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: webrtc/modules/audio_mixer/audio_frame_manipulator.h

Issue 2398083005: Changed ramping functionality of the AudioMixer. (Closed)
Patch Set: Gmock -> gtest, nth -> ith Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/modules/BUILD.gn ('k') | webrtc/modules/audio_mixer/audio_frame_manipulator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/audio_mixer/audio_frame_manipulator.h
diff --git a/webrtc/modules/audio_mixer/audio_frame_manipulator.h b/webrtc/modules/audio_mixer/audio_frame_manipulator.h
index e0ba7eb24a42d2aa557839168b39d08c15db1da9..d3714705b88028641ce0e08e5b7159c27be4a3cd 100644
--- a/webrtc/modules/audio_mixer/audio_frame_manipulator.h
+++ b/webrtc/modules/audio_mixer/audio_frame_manipulator.h
@@ -19,9 +19,9 @@ namespace webrtc {
// Updates the audioFrame's energy (based on its samples).
uint32_t AudioMixerCalculateEnergy(const AudioFrame& audio_frame);
-// Apply linear step function that ramps in/out the audio samples in audio_frame
-void NewMixerRampIn(AudioFrame* audio_frame);
-void NewMixerRampOut(AudioFrame* audio_frame);
+// Ramps up or down the provided audio frame. Ramp(frame, 0, 1) will
the sun 2016/10/11 18:04:13 nit: arguments to Ramp() in comment are in wrong o
aleloi 2016/10/12 08:43:10 Done.
+// linearly increase the samples in the frame from 0 to full volume.
+void Ramp(float current, float target, AudioFrame* audio_frame);
the sun 2016/10/11 18:04:13 use start_gain and target_gain instead.
aleloi 2016/10/12 08:43:10 Done.
// Downmixes or upmixes a frame between stereo and mono.
void RemixFrame(size_t target_number_of_channels, AudioFrame* frame);
« no previous file with comments | « webrtc/modules/BUILD.gn ('k') | webrtc/modules/audio_mixer/audio_frame_manipulator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698