Changed ramping functionality of the AudioMixer.

webrtc/modules/audio_mixer/audio_mixer_impl.cc

 /*
  *  Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 #include "webrtc/modules/audio_mixer/audio_mixer_impl.h"
 
 #include <algorithm>
 #include <functional>
 #include <utility>
 
 #include "webrtc/base/logging.h"
 #include "webrtc/modules/audio_mixer/audio_frame_manipulator.h"
 #include "webrtc/modules/utility/include/audio_frame_operations.h"
 #include "webrtc/system_wrappers/include/trace.h"
 
 namespace webrtc {
 namespace {
 
 class SourceFrame {

[hlundin-webrtc, 2016/10/07 15:03:10]

I'm still inclined to say that this should be a struct.

[aleloi, 2016/10/10 10:58:17]

I'm quite sure that also was the conclusion of our offline discussion. Move the
comparison function out and make SourceFrame a struct. I've changed.

  public:
-  SourceFrame(AudioSourceWithMixStatus* audio_source,
+  SourceFrame(AudioMixerImpl::SourceStatus* source_status,

[hlundin-webrtc, 2016/10/07 15:03:10]

This passing of non-const pointer makes me cringe a bit. But I think it is for
another CL. Let's discuss offline.

[aleloi, 2016/10/10 10:58:17]

Acknowledged.

               AudioFrame* audio_frame,
               bool muted)
-      : audio_source_(audio_source), audio_frame_(audio_frame), muted_(muted) {
+      : source_status_(source_status),
+        audio_frame_(audio_frame),
+        muted_(muted) {
+    RTC_DCHECK(source_status);
+    RTC_DCHECK(audio_frame);
     if (!muted_) {
       energy_ = AudioMixerCalculateEnergy(*audio_frame);
     }
   }
 
-  SourceFrame(AudioSourceWithMixStatus* audio_source,
+  SourceFrame(AudioMixerImpl::SourceStatus* source_status,
               AudioFrame* audio_frame,
               bool muted,
               uint32_t energy)
-      : audio_source_(audio_source),
+      : source_status_(source_status),
         audio_frame_(audio_frame),
         muted_(muted),
-        energy_(energy) {}
-
-  // a.ShouldMixBefore(b) is used to select mixer sources.
-  bool ShouldMixBefore(const SourceFrame& other) const {
-    if (muted_ != other.muted_) {
-      return other.muted_;
-    }
-
-    const auto our_activity = audio_frame_->vad_activity_;
-    const auto other_activity = other.audio_frame_->vad_activity_;
-
-    if (our_activity != other_activity) {
-      return our_activity == AudioFrame::kVadActive;
-    }
-
-    return energy_ > other.energy_;
+        energy_(energy) {
+    RTC_DCHECK(source_status);
+    RTC_DCHECK(audio_frame);
   }
 
-  AudioSourceWithMixStatus* audio_source_ = nullptr;
+  AudioMixerImpl::SourceStatus* source_status_ = nullptr;
   AudioFrame* audio_frame_ = nullptr;
   bool muted_ = true;
   uint32_t energy_ = 0;
 };
 
+// ShouldMixBefore(a, b) is used to select mixer sources.
+bool ShouldMixBefore(const SourceFrame& a, const SourceFrame& b) {
+  if (a.muted_ != b.muted_) {
+    return b.muted_;
+  }
 
-void Ramp(const std::vector<SourceFrame>& mixed_sources_and_frames) {
+  const auto a_activity = a.audio_frame_->vad_activity_;
+  const auto b_activity = b.audio_frame_->vad_activity_;
+
+  if (a_activity != b_activity) {
+    return a_activity == AudioFrame::kVadActive;
+  }
+
+  return a.energy_ > b.energy_;
+}
+
+void RampAndUpdateGain(
+    const std::vector<SourceFrame>& mixed_sources_and_frames) {
   for (const auto& source_frame : mixed_sources_and_frames) {
-    // Ramp in previously unmixed.
-    if (!source_frame.audio_source_->WasMixed()) {
-      NewMixerRampIn(source_frame.audio_frame_);
-    }
-
-    const bool is_mixed = source_frame.audio_source_->IsMixed();
-    // Ramp out currently unmixed.
-    if (source_frame.audio_source_->WasMixed() && !is_mixed) {
-      NewMixerRampOut(source_frame.audio_frame_);
-    }
+    float target_gain_ = source_frame.source_status_->is_mixed_ ? 1 : 0;

[hlundin-webrtc, 2016/10/07 15:03:10]

target_gain without underscore.

[aleloi, 2016/10/10 10:58:17]

Oops!

+    Ramp(source_frame.audio_frame_, source_frame.source_status_->gain_,
+         target_gain_);
+    source_frame.source_status_->gain_ = target_gain_;
   }
 }
 
 // Mix the AudioFrames stored in audioFrameList into mixed_audio.
 int32_t MixFromList(AudioFrame* mixed_audio,
                     const AudioFrameList& audio_frame_list,
                     int32_t id,
                     bool use_limiter) {
   WEBRTC_TRACE(kTraceStream, kTraceAudioMixerServer, id,
                "MixFromList(mixed_audio, audio_frame_list)");
@@ skipping 24 matching lines @@
       // Divide by two to avoid saturation in the mixing.
       // This is only meaningful if the limiter will be used.
       *frame >>= 1;
     }
     RTC_DCHECK_EQ(frame->num_channels_, mixed_audio->num_channels_);
     *mixed_audio += *frame;
   }
   return 0;
 }
 
-MixerAudioSourceList::const_iterator FindSourceInList(
+AudioMixerImpl::MixerAudioSourceList::const_iterator FindSourceInList(
     AudioMixerImpl::Source const* audio_source,
-    MixerAudioSourceList const* audio_source_list) {
+    AudioMixerImpl::MixerAudioSourceList const* audio_source_list) {
   return std::find_if(audio_source_list->begin(), audio_source_list->end(),
-                      [audio_source](const AudioSourceWithMixStatus& p) {
-                        return p.audio_source() == audio_source;
+                      [audio_source](const AudioMixerImpl::SourceStatus& p) {
+                        return p.audio_source_ == audio_source;
                       });
 }
 
-MixerAudioSourceList::iterator FindSourceInList(
+AudioMixerImpl::MixerAudioSourceList::iterator FindSourceInList(
     AudioMixerImpl::Source const* audio_source,
-    MixerAudioSourceList* audio_source_list) {
+    AudioMixerImpl::MixerAudioSourceList* audio_source_list) {
   return std::find_if(audio_source_list->begin(), audio_source_list->end(),
-                      [audio_source](const AudioSourceWithMixStatus& p) {
-                        return p.audio_source() == audio_source;
+                      [audio_source](const AudioMixerImpl::SourceStatus& p) {
+                        return p.audio_source_ == audio_source;
                       });
 }
 
 }  // namespace
 
 std::unique_ptr<AudioMixer> AudioMixer::Create(int id) {
   return AudioMixerImpl::Create(id);
 }
 
 AudioMixerImpl::AudioMixerImpl(int id, std::unique_ptr<AudioProcessing> limiter)
@@ skipping 206 matching lines @@
   RTC_DCHECK_RUN_ON(&thread_checker_);
   WEBRTC_TRACE(kTraceStream, kTraceAudioMixerServer, id_,
                "GetNonAnonymousAudio()");
   AudioFrameList result;
   std::vector<SourceFrame> audio_source_mixing_data_list;
   std::vector<SourceFrame> ramp_list;
 
   // Get audio source audio and put it in the struct vector.
   for (auto& source_and_status : audio_source_list_) {
     auto audio_frame_with_info =
-        source_and_status.audio_source()->GetAudioFrameWithMuted(
+        source_and_status.audio_source_->GetAudioFrameWithMuted(
             id_, static_cast<int>(OutputFrequency()));
 
     const auto audio_frame_info = audio_frame_with_info.audio_frame_info;
     AudioFrame* audio_source_audio_frame = audio_frame_with_info.audio_frame;
 
     if (audio_frame_info == Source::AudioFrameInfo::kError) {
       WEBRTC_TRACE(kTraceWarning, kTraceAudioMixerServer, id_,
                    "failed to GetAudioFrameWithMuted() from source");
       continue;
     }
     audio_source_mixing_data_list.emplace_back(
         &source_and_status, audio_source_audio_frame,
         audio_frame_info == Source::AudioFrameInfo::kMuted);
   }
 
   // Sort frames by sorting function.
   std::sort(audio_source_mixing_data_list.begin(),
-            audio_source_mixing_data_list.end(),
-            std::mem_fn(&SourceFrame::ShouldMixBefore));
+            audio_source_mixing_data_list.end(), ShouldMixBefore);
 
   int max_audio_frame_counter = kMaximumAmountOfMixedAudioSources;
 
   // Go through list in order and put unmuted frames in result list.
   for (const auto& p : audio_source_mixing_data_list) {
     // Filter muted.
     if (p.muted_) {
-      p.audio_source_->SetIsMixed(false);
+      p.source_status_->is_mixed_ = false;
       continue;
     }
 
     // Add frame to result vector for mixing.
     bool is_mixed = false;
     if (max_audio_frame_counter > 0) {
       --max_audio_frame_counter;
       result.push_back(p.audio_frame_);
-      ramp_list.emplace_back(p.audio_source_, p.audio_frame_, false, -1);
+      ramp_list.emplace_back(p.source_status_, p.audio_frame_, false, -1);
       is_mixed = true;
     }
-    p.audio_source_->SetIsMixed(is_mixed);
+    p.source_status_->is_mixed_ = is_mixed;
   }
-  Ramp(ramp_list);
+  RampAndUpdateGain(ramp_list);
   return result;
 }
 
 AudioFrameList AudioMixerImpl::GetAnonymousAudio() {
   RTC_DCHECK_RUN_ON(&thread_checker_);
   WEBRTC_TRACE(kTraceStream, kTraceAudioMixerServer, id_,
                "GetAnonymousAudio()");
   std::vector<SourceFrame> ramp_list;
   AudioFrameList result;
   for (auto& source_and_status : additional_audio_source_list_) {
     const auto audio_frame_with_info =
-        source_and_status.audio_source()->GetAudioFrameWithMuted(
+        source_and_status.audio_source_->GetAudioFrameWithMuted(
             id_, OutputFrequency());
     const auto ret = audio_frame_with_info.audio_frame_info;
     AudioFrame* audio_frame = audio_frame_with_info.audio_frame;
     if (ret == Source::AudioFrameInfo::kError) {
       WEBRTC_TRACE(kTraceWarning, kTraceAudioMixerServer, id_,
                    "failed to GetAudioFrameWithMuted() from audio_source");
       continue;
     }
     if (ret != Source::AudioFrameInfo::kMuted) {
       result.push_back(audio_frame);
       ramp_list.emplace_back(&source_and_status, audio_frame, false, 0);
-      source_and_status.SetIsMixed(true);
+      source_and_status.is_mixed_ = true;
     }
   }
-  Ramp(ramp_list);
+  RampAndUpdateGain(ramp_list);
   return result;
 }
 
 bool AudioMixerImpl::AddAudioSourceToList(
     Source* audio_source,
     MixerAudioSourceList* audio_source_list) const {
   WEBRTC_TRACE(kTraceStream, kTraceAudioMixerServer, id_,
                "AddAudioSourceToList(audio_source, audio_source_list)");
-  audio_source_list->emplace_back(audio_source);
+  audio_source_list->emplace_back(audio_source, false, 0);
   return true;
 }
 
 bool AudioMixerImpl::RemoveAudioSourceFromList(
     Source* audio_source,
     MixerAudioSourceList* audio_source_list) const {
   WEBRTC_TRACE(kTraceStream, kTraceAudioMixerServer, id_,
                "RemoveAudioSourceFromList(audio_source, audio_source_list)");
   const auto iter = FindSourceInList(audio_source, audio_source_list);
   if (iter != audio_source_list->end()) {
@@ skipping 51 matching lines @@
 }
 
 bool AudioMixerImpl::GetAudioSourceMixabilityStatusForTest(
     AudioMixerImpl::Source* audio_source) {
   RTC_DCHECK_RUN_ON(&thread_checker_);
   rtc::CritScope lock(&crit_);
 
   const auto non_anonymous_iter =
       FindSourceInList(audio_source, &audio_source_list_);
   if (non_anonymous_iter != audio_source_list_.end()) {
-    return non_anonymous_iter->IsMixed();
+    return non_anonymous_iter->is_mixed_;
   }
 
   const auto anonymous_iter =
       FindSourceInList(audio_source, &additional_audio_source_list_);
   if (anonymous_iter != audio_source_list_.end()) {
-    return anonymous_iter->IsMixed();
+    return anonymous_iter->is_mixed_;
   }
 
   LOG(LS_ERROR) << "Audio source unknown";
   return false;
 }
 }  // namespace webrtc